eb352a5f6b
* Add transaction to all database tables in roomserver, rename latest events updater to room updater, use room updater for all RS input * Better transaction management * Tweak order * Handle cases where the room does not exist * Other fixes * More tweaks * Fill some gaps * Fill in the gaps * good lord it gets worse * Don't roll back transactions when events rejected * Pass through errors properly * Fix bugs * Fix incorrect error check * Don't panic on nil txns * Tweaks * Hopefully fix panics for good in SQLite this time * Fix rollback * Minor bug fixes with latest event updater * Some review comments * Revert "Some review comments" This reverts commit 0caf8cf53e62c33f7b83c52e9df1d963871f751e. * Fix a couple of bugs * Clearer commit and rollback results * Remove unnecessary prepares
109 lines
3.7 KiB
Go
109 lines
3.7 KiB
Go
// Copyright 2017-2018 New Vector Ltd
|
|
// Copyright 2019-2020 The Matrix.org Foundation C.I.C.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package postgres
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
|
|
"github.com/matrix-org/dendrite/internal"
|
|
"github.com/matrix-org/dendrite/internal/sqlutil"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/tables"
|
|
"github.com/matrix-org/dendrite/roomserver/types"
|
|
)
|
|
|
|
const eventJSONSchema = `
|
|
-- Stores the JSON for each event. This kept separate from the main events
|
|
-- table to keep the rows in the main events table small.
|
|
CREATE TABLE IF NOT EXISTS roomserver_event_json (
|
|
-- Local numeric ID for the event.
|
|
event_nid BIGINT NOT NULL PRIMARY KEY,
|
|
-- The JSON for the event.
|
|
-- Stored as TEXT because this should be valid UTF-8.
|
|
-- Not stored as a JSONB because we always just pull the entire event
|
|
-- so there is no point in postgres parsing it.
|
|
-- Not stored as JSON because we already validate the JSON in the server
|
|
-- so there is no point in postgres validating it.
|
|
-- TODO: Should we be compressing the events with Snappy or DEFLATE?
|
|
event_json TEXT NOT NULL
|
|
);
|
|
`
|
|
|
|
const insertEventJSONSQL = "" +
|
|
"INSERT INTO roomserver_event_json (event_nid, event_json) VALUES ($1, $2)" +
|
|
" ON CONFLICT (event_nid) DO UPDATE SET event_json=$2"
|
|
|
|
// Bulk event JSON lookup by numeric event ID.
|
|
// Sort by the numeric event ID.
|
|
// This means that we can use binary search to lookup by numeric event ID.
|
|
const bulkSelectEventJSONSQL = "" +
|
|
"SELECT event_nid, event_json FROM roomserver_event_json" +
|
|
" WHERE event_nid = ANY($1)" +
|
|
" ORDER BY event_nid ASC"
|
|
|
|
type eventJSONStatements struct {
|
|
insertEventJSONStmt *sql.Stmt
|
|
bulkSelectEventJSONStmt *sql.Stmt
|
|
}
|
|
|
|
func createEventJSONTable(db *sql.DB) error {
|
|
_, err := db.Exec(eventJSONSchema)
|
|
return err
|
|
}
|
|
|
|
func prepareEventJSONTable(db *sql.DB) (tables.EventJSON, error) {
|
|
s := &eventJSONStatements{}
|
|
|
|
return s, sqlutil.StatementList{
|
|
{&s.insertEventJSONStmt, insertEventJSONSQL},
|
|
{&s.bulkSelectEventJSONStmt, bulkSelectEventJSONSQL},
|
|
}.Prepare(db)
|
|
}
|
|
|
|
func (s *eventJSONStatements) InsertEventJSON(
|
|
ctx context.Context, txn *sql.Tx, eventNID types.EventNID, eventJSON []byte,
|
|
) error {
|
|
_, err := s.insertEventJSONStmt.ExecContext(ctx, int64(eventNID), eventJSON)
|
|
return err
|
|
}
|
|
|
|
func (s *eventJSONStatements) BulkSelectEventJSON(
|
|
ctx context.Context, txn *sql.Tx, eventNIDs []types.EventNID,
|
|
) ([]tables.EventJSONPair, error) {
|
|
stmt := sqlutil.TxStmt(txn, s.bulkSelectEventJSONStmt)
|
|
rows, err := stmt.QueryContext(ctx, eventNIDsAsArray(eventNIDs))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer internal.CloseAndLogIfError(ctx, rows, "bulkSelectEventJSON: rows.close() failed")
|
|
|
|
// We know that we will only get as many results as event NIDs
|
|
// because of the unique constraint on event NIDs.
|
|
// So we can allocate an array of the correct size now.
|
|
// We might get fewer results than NIDs so we adjust the length of the slice before returning it.
|
|
results := make([]tables.EventJSONPair, len(eventNIDs))
|
|
i := 0
|
|
for ; rows.Next(); i++ {
|
|
result := &results[i]
|
|
var eventNID int64
|
|
if err := rows.Scan(&eventNID, &result.EventJSON); err != nil {
|
|
return nil, err
|
|
}
|
|
result.EventNID = types.EventNID(eventNID)
|
|
}
|
|
return results[:i], rows.Err()
|
|
}
|