jimzah/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2024-11-26 20:12:44 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fdwrite.c: initialize pointers to NULL and a few other cleanups

Browse Source 
1. Both trackbuf and vrfybuf are initialized to
zero (NULL). While it's okay to initialize pointers
to zero, to keep consistency, as they're explicitly
pointers, it's better to just use NULL ((void *)0)
instead of 0 (both are equivalent to the compilers).

2. Call free() for both trackbuf and vrfybuf after
their job has been done.

3. Remove the register keyword. Compilers generally
ignore this keyword (except for very very old compilers
and CPUs).

4. Remove the ctype.h header. It's not being used
anywhere in the file.

Signed-off-by: rilysh <nightquick@proton.me>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1059
This commit is contained in:
rilysh 2024-04-11 12:23:33 -06:00 committed by Warner Losh
parent 215c0a5158
commit 16e5eb212f
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.sbin/fdwrite/fdwrite.c
View File

@ -10,7 +10,6 @@
*
*/
#include <ctype.h>
#include <err.h>
#include <fcntl.h>
#include <paths.h>
@ -26,7 +25,7 @@ format_track(int fd, int cyl, int secs, int head, int rate,
int gaplen, int secsize, int fill, int interleave)
{
struct fd_formb f;
register int i,j;
int i, j;
int il[100];
memset(il,0,sizeof il);
@ -68,7 +67,7 @@ main(int argc, char **argv)
int bpt, verbose=1, nbytes=0, track;
int interactive = 1;
const char *device= "/dev/fd0";
char *trackbuf = 0,*vrfybuf = 0;
char *trackbuf = NULL, *vrfybuf = NULL;
struct fd_type fdt;
FILE *tty;
@ -192,5 +191,8 @@ main(int argc, char **argv)
}
if(verbose)
printf("%d bytes on %d flopp%s\n",nbytes,fdn,fdn==1?"y":"ies");
free(trackbuf);
free(vrfybuf);
exit(0);
}