jimzah/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2024-11-27 00:33:30 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix several dev_clone callbacks to avoid out-of-bounds reads

Browse Source 
Use strncmp() instead of bcmp(), so that we don't have to find the
minimum of the string lengths before comparing.

Reviewed by:	kib
Reported by:	KASAN
MFC after:	3 days
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D29463
This commit is contained in:
Mark Johnston 2021-03-28 11:08:36 -04:00
parent 1c1ff79795
commit 3428b6c050
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/sound/pcm/dsp.c
View File

@ -2294,8 +2294,7 @@ dsp_stdclone(char *name, char *namep, char *sep, int use_sep, int *u, int *c)
size_t len;
len = strlen(namep);
if (bcmp(name, namep, len) != 0)
if (strncmp(name, namep, len) != 0)
return (ENODEV);
name += len;

2
sys/kern/kern_conf.c
View File

@ -1255,7 +1255,7 @@ dev_stdclone(char *name, char **namep, const char *stem, int *unit)
int u, i;
i = strlen(stem);
if (bcmp(stem, name, i) != 0)
if (strncmp(stem, name, i) != 0)
return (0);
if (!isdigit(name[i]))
return (0);