jimzah/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2024-12-04 18:59:37 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

MFC r311688:

Browse Source 
Fix logic error in gvinum's gv_set_sd_state()

With clang 4.0.0, I'm getting the following warnings:

    sys/geom/vinum/geom_vinum_state.c:186:7: error: logical not is only
    applied to the left hand side of this bitwise operator
    [-Werror,-Wlogical-not-parentheses]
                    if (!flags & GV_SETSTATE_FORCE)
                        ^      ~

The logical not operator should obiously be called after masking.

Reviewed by:	mav, pfg
Differential Revision:	https://reviews.freebsd.org/D9093
This commit is contained in:
Dimitry Andric 2017-01-11 21:01:49 +00:00
parent 76a8e30c15
commit 3c8c79a883
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/stable/10/; revision=311939
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/geom/vinum/geom_vinum_state.c
View File

@ -183,7 +183,7 @@ gv_set_sd_state(struct gv_sd *s, int newstate, int flags)
* Only do this if we're forced, since it usually is done
* internally, and then we do use the force flag.
*/
if (!flags & GV_SETSTATE_FORCE)
if (!(flags & GV_SETSTATE_FORCE))
return (GV_ERR_SETSTATE);
break;