pvscsi: maximum target number is one less than number of targets
Some checks are pending
Cross-build Kernel / ${{ matrix.target_arch }} ${{ matrix.os }} (${{ matrix.compiler }}) (clang-12, /usr/lib/llvm-12/bin, ubuntu-20.04, bmake libarchive-dev clang-12 lld-12, amd64, amd64) (push) Waiting to run
Cross-build Kernel / ${{ matrix.target_arch }} ${{ matrix.os }} (${{ matrix.compiler }}) (clang-12, /usr/lib/llvm-12/bin, ubuntu-20.04, bmake libarchive-dev clang-12 lld-12, arm64, aarch64) (push) Waiting to run
Cross-build Kernel / ${{ matrix.target_arch }} ${{ matrix.os }} (${{ matrix.compiler }}) (clang-13, /opt/homebrew/opt/llvm@13/bin, macos-latest, bmake libarchive llvm@13, amd64, amd64) (push) Waiting to run
Cross-build Kernel / ${{ matrix.target_arch }} ${{ matrix.os }} (${{ matrix.compiler }}) (clang-13, /opt/homebrew/opt/llvm@13/bin, macos-latest, bmake libarchive llvm@13, arm64, aarch64) (push) Waiting to run
Cross-build Kernel / ${{ matrix.target_arch }} ${{ matrix.os }} (${{ matrix.compiler }}) (clang-14, /usr/lib/llvm-14/bin, ubuntu-22.04, bmake libarchive-dev clang-14 lld-14, amd64, amd64) (push) Waiting to run
Cross-build Kernel / ${{ matrix.target_arch }} ${{ matrix.os }} (${{ matrix.compiler }}) (clang-14, /usr/lib/llvm-14/bin, ubuntu-22.04, bmake libarchive-dev clang-14 lld-14, arm64, aarch64) (push) Waiting to run

Fix the number of targets we inquiry to be one less than the maximum
number of targets adapter reports.  This gets rid of the errors reported
on VMware Workstation:

(probe36:pvscsi0:0:65:0): INQUIRY. CDB: 12 00 00 00 24 00
(probe36:pvscsi0:0:65:0): CAM status: CCB request completed with an error

While here, print the maximum number of targets.

Reviewed by:	imp
Differential Revision:	https://reviews.freebsd.org/D39867

(cherry picked from commit 6abf81b3d6)
This commit is contained in:
Yuri Pankov 2023-05-05 11:48:57 +02:00 committed by Zhenlei Huang
parent d4820e1727
commit 770498cf8b

View File

@ -1410,7 +1410,7 @@ finish_ccb:
cpi->hba_misc = PIM_NOBUSRESET | PIM_UNMAPPED;
cpi->hba_eng_cnt = 0;
/* cpi->vuhba_flags = 0; */
cpi->max_target = sc->max_targets;
cpi->max_target = sc->max_targets - 1;
cpi->max_lun = 0;
cpi->async_flags = 0;
cpi->hpath_id = 0;
@ -1682,6 +1682,7 @@ pvscsi_attach(device_t dev)
PVSCSI_MAX_REQ_QUEUE_DEPTH);
device_printf(sc->dev, "Use Msg: %d\n", sc->use_msg);
device_printf(sc->dev, "Max targets: %d\n", sc->max_targets);
device_printf(sc->dev, "REQ num pages: %d\n", sc->req_ring_num_pages);
device_printf(sc->dev, "CMP num pages: %d\n", sc->cmp_ring_num_pages);
device_printf(sc->dev, "MSG num pages: %d\n", sc->msg_ring_num_pages);