From 7e9803e8659bb3d2aa88f5f268095edc31257230 Mon Sep 17 00:00:00 2001 From: Robert Watson Date: Sat, 14 Jan 2006 11:40:32 +0000 Subject: [PATCH] In ncp_sysctl_connstat(), the SLIST_FOREACH() logic to check 'error' resulted in deadcode, as 'error' could never be 0. What this logic was originally meant to handle is not clear -- it's been this way (broken) since at least RELENG_4. Found with: Coverity Prevent(tm) MFC after: 3 days --- sys/netncp/ncp_conn.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sys/netncp/ncp_conn.c b/sys/netncp/ncp_conn.c index 270f3007a544..1455d6f092dd 100644 --- a/sys/netncp/ncp_conn.c +++ b/sys/netncp/ncp_conn.c @@ -656,13 +656,7 @@ ncp_sysctl_connstat(SYSCTL_HANDLER_ARGS) if (error) break; /* I can't do conn_lock while list is locked */ ncp->nc_lwant++; - if (!error) { - ncp_conn_getinfo(ncp, &ncs); - } else { - bzero(&ncs,sizeof(ncs)); - ncs.connRef = ncp->nc_id; - strcpy(ncs.li.server,"***"); - } + ncp_conn_getinfo(ncp, &ncs); ncp->nc_lwant--; error = SYSCTL_OUT(req, &ncs, sizeof(ncs)); }