mirror of
https://github.com/freebsd/freebsd-src.git
synced 2024-11-28 09:02:44 +00:00
Better memory handling:
- It is acceptable to call free(3) when the given pointer itself is NULL, so we do not need to determine NULL before passing a pointer to free(3) - Handle failure of malloc(3) MT6/5 Candidate Submitted by: Dan Lukes <dan at obluda cz> PR: bin/83352
This commit is contained in:
parent
ef95d02dd0
commit
ae73eb3a7f
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=147949
@ -97,8 +97,7 @@ cam_getccb(struct cam_device *dev)
|
||||
void
|
||||
cam_freeccb(union ccb *ccb)
|
||||
{
|
||||
if (ccb != NULL)
|
||||
free(ccb);
|
||||
free(ccb);
|
||||
}
|
||||
|
||||
/*
|
||||
@ -708,8 +707,7 @@ cam_close_device(struct cam_device *dev)
|
||||
|
||||
cam_close_spec_device(dev);
|
||||
|
||||
if (dev != NULL)
|
||||
free(dev);
|
||||
free(dev);
|
||||
}
|
||||
|
||||
void
|
||||
@ -757,6 +755,11 @@ cam_device_dup(struct cam_device *device)
|
||||
}
|
||||
|
||||
newdev = malloc(sizeof(struct cam_device));
|
||||
if (newdev == NULL) {
|
||||
snprintf(cam_errbuf, CAM_ERRBUF_SIZE,
|
||||
"%s: couldn't malloc CAM device structure", func_name);
|
||||
return(NULL);
|
||||
}
|
||||
|
||||
bcopy(device, newdev, sizeof(struct cam_device));
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user