- Don't print an errno string when reporting dropped samples.

- Prevent an unsuccessful exec() of a target program from triggering
  a false 'dropped samples' message.
This commit is contained in:
Joseph Koshy 2005-12-24 17:00:33 +00:00
parent 96ff9a2bf4
commit bea6aa93d0
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=153704

View File

@ -376,7 +376,8 @@ main(int argc, char **argv)
args.pa_printfile = stderr; args.pa_printfile = stderr;
args.pa_interval = DEFAULT_WAIT_INTERVAL; args.pa_interval = DEFAULT_WAIT_INTERVAL;
STAILQ_INIT(&args.pa_head); STAILQ_INIT(&args.pa_head);
bzero(&ds_start, sizeof(ds_start));
bzero(&ds_end, sizeof(ds_end));
ev = NULL; ev = NULL;
while ((option = getopt(argc, argv, "CD:EO:P:R:S:Wc:dgk:n:o:p:s:t:w:")) while ((option = getopt(argc, argv, "CD:EO:P:R:S:Wc:dgk:n:o:p:s:t:w:"))
@ -971,12 +972,12 @@ main(int argc, char **argv)
err(EX_OSERR, "ERROR: Cannot retrieve driver " err(EX_OSERR, "ERROR: Cannot retrieve driver "
"statistics"); "statistics");
if (ds_start.pm_intr_bufferfull != ds_end.pm_intr_bufferfull) if (ds_start.pm_intr_bufferfull != ds_end.pm_intr_bufferfull)
warn("WARNING: some samples were dropped. Please " warnx("WARNING: some samples were dropped. Please "
"consider tuning the \"kern.hwpmc.nsamples\" " "consider tuning the \"kern.hwpmc.nsamples\" "
"tunable."); "tunable.");
if (ds_start.pm_buffer_requests_failed != if (ds_start.pm_buffer_requests_failed !=
ds_end.pm_buffer_requests_failed) ds_end.pm_buffer_requests_failed)
warn("WARNING: some events were discarded. Please " warnx("WARNING: some events were discarded. Please "
"consider tuning the \"kern.hwpmc.nbuffers\" " "consider tuning the \"kern.hwpmc.nbuffers\" "
"tunable."); "tunable.");
} }