jimzah/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2024-12-03 19:08:58 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Disable interrupts when calling into SAL for PCI configuration

Browse Source 
cycles. This serves 2 purposes:
1.  It prevents preemption and CPU migration while running SAL code.
2.  It reduces the chance of stack overflows: we're supposed to enter
    SAL with at least 16KB of either memory- or register stack space,
    which we can't do without switching to a different stack.
This commit is contained in:
Marcel Moolenaar 2010-03-22 03:06:11 +00:00
parent c56153c577
commit cc7a041c2b
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=205432
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/ia64/pci/pci_cfgreg.c
View File

@ -28,6 +28,7 @@
*/
#include <sys/param.h>
#include <machine/cpufunc.h>
#include <machine/pci_cfgreg.h>
#include <machine/sal.h>
@ -66,6 +67,7 @@ uint32_t
pci_cfgregread(int bus, int slot, int func, int reg, int len)
{
struct ia64_sal_result res;
register_t is;
u_long addr;
addr = pci_sal_address(0, bus, slot, func, reg);
@ -75,17 +77,18 @@ pci_cfgregread(int bus, int slot, int func, int reg, int len)
if (!pci_valid_access(reg, len))
return (~0);
is = intr_disable();
res = ia64_sal_entry(SAL_PCI_CONFIG_READ, addr, len, 0, 0, 0, 0, 0);
if (res.sal_status < 0)
return (~0);
intr_restore(is);
return (res.sal_result[0]);
return ((res.sal_status < 0) ? ~0 : res.sal_result[0]);
}
void
pci_cfgregwrite(int bus, int slot, int func, int reg, uint32_t data, int len)
{
struct ia64_sal_result res;
register_t is;
u_long addr;
addr = pci_sal_address(0, bus, slot, func, reg);
@ -95,5 +98,7 @@ pci_cfgregwrite(int bus, int slot, int func, int reg, uint32_t data, int len)
if (!pci_valid_access(reg, len))
return;
is = intr_disable();
res = ia64_sal_entry(SAL_PCI_CONFIG_WRITE, addr, len, data, 0, 0, 0, 0);
intr_restore(is);
}