jimzah/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src.git synced 2024-12-04 10:19:26 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Lock interface address list lock around ifaddr inserts and deletes

Browse Source 
in at_control().  This locking is not yet complete but should prevent
some classes of race conditions.

MFC after:	2 weeks
This commit is contained in:
Robert Watson 2009-04-19 22:01:38 +00:00
parent 37dd6c71ca
commit f25cc1d0d9
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=191281
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/netatalk/at_control.c
View File

@ -191,7 +191,6 @@ at_control(struct socket *so, u_long cmd, caddr_t data, struct ifnet *ifp,
ifa = (struct ifaddr *)aa;
IFA_LOCK_INIT(ifa);
ifa->ifa_refcnt = 1;
TAILQ_INSERT_TAIL(&ifp->if_addrhead, ifa, ifa_link);
/*
* As the at_ifaddr contains the actual sockaddrs,
@ -214,6 +213,9 @@ at_control(struct socket *so, u_long cmd, caddr_t data, struct ifnet *ifp,
* and link it all together
*/
aa->aa_ifp = ifp;
IF_ADDR_LOCK(ifp);
TAILQ_INSERT_TAIL(&ifp->if_addrhead, ifa, ifa_link);
IF_ADDR_UNLOCK(ifp);
} else {
/*
* If we DID find one then we clobber any routes
@ -296,7 +298,9 @@ at_control(struct socket *so, u_long cmd, caddr_t data, struct ifnet *ifp,
* remove the ifaddr from the interface
*/
ifa0 = (struct ifaddr *)aa;
IF_ADDR_LOCK(ifp);
TAILQ_REMOVE(&ifp->if_addrhead, ifa0, ifa_link);
IF_ADDR_UNLOCK(ifp);
/*
* Now remove the at_ifaddr from the parallel structure