Add a test to verify compatibility with archives with

odd hardlinks.  I need to extend this to test pax extended
archives with bodies attached to hardlinks and other less-common cases.
This commit is contained in:
Tim Kientzle 2008-01-31 07:47:38 +00:00
parent 6f6dfc16c2
commit fae7e96d82
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=175843
3 changed files with 145 additions and 0 deletions

View File

@ -9,6 +9,7 @@ LA_SRCS!=make -f ${LA_SRCDIR}/Makefile -V SRCS
TESTFILES= \
test_compat_gtar_1.tgz \
test_compat_tar_hardlink_1.tar \
test_compat_zip_1.zip \
test_read_format_gtar_sparse_1_13.tgz \
test_read_format_gtar_sparse_1_17.tgz \
@ -23,6 +24,7 @@ TESTS= \
test_archive_api_feature.c \
test_bad_fd.c \
test_compat_gtar.c \
test_compat_tar_hardlink.c \
test_compat_zip.c \
test_empty_write.c \
test_entry.c \

View File

@ -0,0 +1,104 @@
/*-
* Copyright (c) 2003-2007 Tim Kientzle
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR(S) ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR(S) BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "test.h"
__FBSDID("$FreeBSD$");
/*
* Background: There are two written standards for the tar file format.
* The first is the POSIX 1988 "ustar" format, the second is the 2001
* "pax extended" format that builds on the "ustar" format by adding
* support for generic additional attributes. Buried in the details
* is one frustrating incompatibility: The 1988 standard says that
* tar readers MUST ignore the size field on hardlink entries; the
* 2001 standard says that tar readers MUST obey the size field on
* hardlink entries. libarchive tries to navigate this particular
* minefield by using auto-detect logic to guess whether it should
* or should not obey the size field.
*
* This test tries to probe the boundaries of such handling; the test
* archives here were adapted from real archives created by real
* tar implementations that are (as of early 2008) apparently still
* in use.
*/
static void
test_compat_tar_hardlink_1(void)
{
char name[1024];
struct archive_entry *ae;
struct archive *a;
assert((a = archive_read_new()) != NULL);
assertEqualIntA(a, ARCHIVE_OK, archive_read_support_compression_all(a));
assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
sprintf(name, "%s/test_compat_tar_hardlink_1.tar", refdir);
assertEqualIntA(a, ARCHIVE_OK, archive_read_open_filename(a, name, 10240));
/* Read first entry, which is a regular file. */
assertEqualIntA(a, ARCHIVE_OK, archive_read_next_header(a, &ae));
assertEqualString("xmcd-3.3.2/docs_d/READMf",
archive_entry_pathname(ae));
assertEqualString(NULL, archive_entry_hardlink(ae));
assertEqualInt(321, archive_entry_size(ae));
assertEqualInt(1082575645, archive_entry_mtime(ae));
assertEqualInt(1851, archive_entry_uid(ae));
assertEqualInt(3, archive_entry_gid(ae));
assertEqualInt(0100444, archive_entry_mode(ae));
/* Read second entry, which is a hard link at the end of archive. */
assertEqualIntA(a, ARCHIVE_OK, archive_read_next_header(a, &ae));
assertEqualString("xmcd-3.3.2/README",
archive_entry_pathname(ae));
assertEqualString(
"xmcd-3.3.2/docs_d/READMf",
archive_entry_hardlink(ae));
assertEqualInt(0, archive_entry_size(ae));
assertEqualInt(1082575645, archive_entry_mtime(ae));
assertEqualInt(1851, archive_entry_uid(ae));
assertEqualInt(3, archive_entry_gid(ae));
assertEqualInt(0100444, archive_entry_mode(ae));
/* Verify the end-of-archive. */
/*
* This failed in libarchive 2.4.12 because the tar reader
* tried to obey the size field for the hard link and ended
* up running past the end of the file.
*/
assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
/* Verify that the format detection worked. */
assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_NONE);
assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR);
assertEqualInt(ARCHIVE_OK, archive_read_close(a));
assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
}
DEFINE_TEST(test_compat_tar_hardlink)
{
test_compat_tar_hardlink_1();
}

View File

@ -0,0 +1,39 @@
$FreeBSD$
begin 644 test_compat_tar_hardlink_1.tar
M>&UC9"TS+C,N,B]D;V-S7V0O4D5!1$UF````````````````````````````
M````````````````````````````````````````````````````````````
M`````````````"`@(#0T-"``("`S-#<S(``@("`@(#,@`"`@("`@("`@-3`Q
M(#$P,#0Q-30U-#,U("`@-S8U-``@````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M``````````````````````!X>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX
M>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX
M>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX
M>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX
M>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX
M>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX
M>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'AX
M>'AX>'AX>'AX>'AX>'AX>'AX>'AX>'@`````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M`````````````````````````````````````````````'AM8V0M,RXS+C(O
M4D5!1$U%````````````````````````````````````````````````````
M```````````````````````````````````````````````````````````@
M("`T-#0@`"`@,S0W,R``("`@("`S(``@("`@("`@(#4P,2`Q,#`T,34T-30S
M-2`@,3(R,#<`(#%X;6-D+3,N,RXR+V1O8W-?9"]214%$368`````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
&````````
`
end