freebsd-src/lib/libfetch
Pietro Cerutti ab7a79806e libfetch: don't include fragments in HTTP requests
Fragments are reserved for client-side processing, see
https://www.rfc-editor.org/rfc/rfc9110.html#section-7.1

Also, some servers don't like to receive HTTP requests with fragments.

```
$ fetch 'https://dropbox.com/a/b'
fetch: https://dropbox.com/a/b: Not Found

$ fetch 'https://dropbox.com/a/b#'
fetch: https://dropbox.com/a/b#: Bad Request
```

This is a real-world scenario, where some download link from dropbox
(eventually) redirects to an URL with a fragment:

```
$ fetch -v 'https://www.dropbox.com/sh/<some>/<thing>?dl=1' 2>&1 | grep requesting
requesting https://www.dropbox.com/sh/<some>/<thing>?dl=1
requesting https://www.dropbox.com/scl/fo/<foo>/<bar>?rlkey=<baz>&dl=1
requesting https://<boo>.dl.dropboxusercontent.com/zip_download_get/<some-long-strig>#
```

See how the last redirect ends with a `#`.

Currently, libfetch includes the ending fragment and makes it impossible
to download the file.

Differential Revision:	https://reviews.freebsd.org/D46318
MFC after:		2 weeks

(cherry picked from commit 1af7d5f389)
2024-09-05 14:05:15 +00:00
..
common.c libfetch: don't rely on ca_root_nss for certificate validation 2023-10-05 02:03:16 +02:00
common.h
fetch.3 libfetch, fetch: Stop recommending the use of ca_root_nss. 2023-12-13 17:23:57 +01:00
fetch.c libfetch: don't include fragments in HTTP requests 2024-09-05 14:05:15 +00:00
fetch.h
file.c Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:42 -06:00
ftp.c Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:42 -06:00
ftp.errors Remove $FreeBSD$: one-line sh pattern 2023-08-16 11:55:03 -06:00
http.c Remove $FreeBSD$: one-line .c pattern 2023-08-16 11:54:42 -06:00
http.errors Remove $FreeBSD$: one-line sh pattern 2023-08-16 11:55:03 -06:00
Makefile Remove $FreeBSD$: one-line sh pattern 2023-08-16 11:55:03 -06:00
Makefile.depend Remove $FreeBSD$: one-line sh pattern 2023-08-16 11:55:03 -06:00
Makefile.depend.options Remove $FreeBSD$: one-line sh pattern 2023-08-16 11:55:03 -06:00