mirror of
https://github.com/freebsd/freebsd-src.git
synced 2024-12-02 19:22:47 +00:00
3b44d03524
MFC r316938,r316953: r316938: savecore: fix space calculation with respect to `minfree` in check_space(..) - Use strtoll(3) instead of atoi(3), because atoi(3) limits the representable data to INT_MAX. Check the values received from strtoll(3), trimming trailing whitespace off the end to maintain POLA. - Use `KiB` instead of `kB` when describing free space, total space, etc. I am now fully aware of `KiB` being the IEC standard for 1024 bytes and `kB` being the IEC standard for 1000 bytes. - Store available number of KiB in `available` so it can be more easily queried and compared to ensure that there are enough KiB to store the dump image on disk. - Print out the reserved space on disk, per `minfree`, so end-users can troubleshoot why check_space(..) is reporting that there isn't enough free space. Tested with: positive/negative cases (see review); make tinderbox r316953: Switch back to non-IEC units for 1024 bytes I was swayed a little too quickly when I saw the wiki page discussing kB vs KiB. Switch back as none of the code in base openly uses IEC units via humanize_number(3) (which was my next step), and there's a large degree of dislike with IEC vs more SI-like units. |
||
|---|---|---|
| .. | ||
| adjkerntz | ||
| atm | ||
| badsect | ||
| bsdlabel | ||
| camcontrol | ||
| ccdconfig | ||
| clri | ||
| comcontrol | ||
| conscontrol | ||
| ddb | ||
| devd | ||
| devfs | ||
| dhclient | ||
| dmesg | ||
| dump | ||
| dumpfs | ||
| dumpon | ||
| etherswitchcfg | ||
| fdisk | ||
| fdisk_pc98 | ||
| ffsinfo | ||
| fsck | ||
| fsck_ffs | ||
| fsck_msdosfs | ||
| fsdb | ||
| fsirand | ||
| gbde | ||
| geom | ||
| ggate | ||
| growfs | ||
| gvinum | ||
| hastctl | ||
| hastd | ||
| ifconfig | ||
| init | ||
| ipf | ||
| ipfw | ||
| iscontrol | ||
| kldconfig | ||
| kldload | ||
| kldstat | ||
| kldunload | ||
| ldconfig | ||
| mca | ||
| md5 | ||
| mdconfig | ||
| mdmfs | ||
| mknod | ||
| mksnap_ffs | ||
| mount | ||
| mount_cd9660 | ||
| mount_fusefs | ||
| mount_msdosfs | ||
| mount_nfs | ||
| mount_nullfs | ||
| mount_udf | ||
| mount_unionfs | ||
| nandfs | ||
| natd | ||
| newfs | ||
| newfs_msdos | ||
| newfs_nandfs | ||
| nfsiod | ||
| nos-tun | ||
| nvmecontrol | ||
| pfctl | ||
| pflogd | ||
| ping | ||
| ping6 | ||
| quotacheck | ||
| rcorder | ||
| reboot | ||
| recoverdisk | ||
| resolvconf | ||
| restore | ||
| route | ||
| routed | ||
| rtsol | ||
| savecore | ||
| sconfig | ||
| setkey | ||
| shutdown | ||
| spppcontrol | ||
| sunlabel | ||
| swapon | ||
| sysctl | ||
| tests | ||
| tunefs | ||
| umount | ||
| zfsbootcfg | ||
| Makefile | ||
| Makefile.amd64 | ||
| Makefile.arm | ||
| Makefile.i386 | ||
| Makefile.ia64 | ||
| Makefile.inc | ||
| Makefile.mips | ||
| Makefile.pc98 | ||
| Makefile.sparc64 | ||