freebsd-src/lib
Bill Paul a393cc06f5 Fixed a rather serious bug that presents itself when FreeBSD is configured
as an NIS client. The pw_breakout_yp routines that are used to populate the
_pw_passwd structire only do anything if the bits in the pw_fields member
_pw_passwd are cleared. Unfortunately, we can get into a state where
pw_fields has garbage in it right before the YP lookup functions are
called, which causes the breakout functions to screw up in a big way.
Here's how to duplicate the problem:

- Configure FreeBSD as an NIS client
- Log in as a user who's password database records reside only in
  the NIS passwd maps.
- Type ps -aux

Result: your processes appear to be owned by 'root' or 'deamon.'
/bin/ls can exhibit the same problem.

The reason this happens:

- When ps(1) needs to match a username to a UID, it calls getpwuid().

- root is in the local password file, so getpwuid() calls  __hashpw()
  and __hashpw() populates the _pw_passwd struct, including the pw_fields
  member. This happens before NIS lookups take place because, by coincidence,
  ps(1) tends to display processes owned by root before it happens upon
  a proccess owned by you.

- When your UID comes up, __hashpw() fails to find your entry in the
  local password database, so it bails out, BUT THE BITS IN THE pw_fields
  STRUCTURE OF _pw_passwd ARE NEVER CLEARED AND STILL CONTAIN INFORMATION
  FROM THE PREVIOUS CALL TO __hash_pw()!!

- If we have NIS enabled, the NIS lookup functions are called.

- The pw_breakout_yp routines see that the pw_fields bits are set and
  decline to place the data retrieved from the NIS passwd maps into the
  _pw_passwd structure.

- getpwuid() returns the results of the last __hashpw() lookup instead
  of the valid NIS data.

- Hijinxs ensue when user_from_uid() caches this bogus information and
  starts handing out the wrong usernames.

AAAARRRRRRRRRGGGGGGHHHHHHHHHH!!!

*Please* don't tell me I'm the only person to have noticed this.

Fixed by having __hashpw() check the state of pw_fields just before
bailing out on a failed lookup and clearing away any leftover garbage.
What a fun way to spend an afternoon.
1995-02-03 01:09:35 +00:00
..
csu/i386
libc Fixed a rather serious bug that presents itself when FreeBSD is configured 1995-02-03 01:09:35 +00:00
libcom_err Don't call _doprnt, which doesn't exist; use vfprintf. 1995-01-23 22:53:12 +00:00
libcompat
libcrypt Install shared libraries in ${DESTDIR}${SHLIBDIR} instead of in 1994-11-14 06:44:45 +00:00
libcurses tputs: (char) -> (int) 1994-12-10 23:02:33 +00:00
libedit
libf2c
libF77
libforms Implemented height field for text fields so they can now be more than 1995-02-01 04:06:37 +00:00
libI77
libkvm
libm
libmd Eliminate a bogus tab. 1995-01-24 00:13:56 +00:00
libmytinfo Prototypes... 1994-12-10 22:56:53 +00:00
libncurses Back out bkgd changes, now acts per braindamaged sysv standard 1995-01-16 17:33:33 +00:00
libpam/modules In the non-PARANOID case, make sure to set `notickets' to 0 sothat login.c 1995-01-20 23:07:10 +00:00
libpcap Add the Packet Capture Library from Michael Reifenberger. 1995-01-20 04:13:07 +00:00
libresolv
librpc
librpcsvc
libscsi Clean up handling of unspecified names. Clarify man page. 1995-01-26 23:48:41 +00:00
libskey
libss Make Jordan happy: 1995-01-23 18:56:40 +00:00
libtelnet
libterm
libtermcap tputs: (char) -> (int) 1994-12-10 22:01:25 +00:00
libutil
liby
msun
ncurses/ncurses termcap.h now belongs to system 1994-12-04 02:43:41 +00:00
rpcsvc
Makefile added libscsi 1995-01-24 12:10:42 +00:00
Makefile.inc