Go to file
Alfred Perlstein 435cdf88ea Fix a race where timeout/untimeout could cause crashes for Giant locked
code.

The bug:

There exists a race condition for timeout/untimeout(9) due to the
way that the softclock thread dequeues timeouts.

The softclock thread sets the c_func and c_arg of the callout to
NULL while holding the callout lock but not Giant.  It then drops
the callout lock and acquires Giant.

It is at this point where untimeout(9) on another cpu/thread could
be called.

Since c_arg and c_func are cleared, untimeout(9) does not touch the
callout and returns as if the callout is canceled.

The softclock then tries to acquire Giant and likely blocks due to
the other cpu/thread holding it.

The other cpu/thread then likely deallocates the backing store that
c_arg points to and finishes working and hence drops Giant.

Softclock resumes and acquires giant and calls the function with
the now free'd c_arg and we have corruption/crash.

The fix:

We need to track curr_callout even for timeout(9) (LOCAL_ALLOC)
callouts.  We need to free the callout after the softclock processes
it to deal with the race here.

Obtained from: Juniper Networks, iedowse
Reviewed by: jhb, iedowse
MFC After: 2 weeks.
2008-03-22 07:29:45 +00:00
bin uuidgen has been repo-copied from usr.bin/ to bin/ to match its "new" 2008-03-13 17:38:06 +00:00
cddl Remove _SOLARIS_C_SOURCE now that it doesn't do anything in FreeBSD 2007-11-28 22:58:09 +00:00
compat/opensolaris
contrib Resolve conflicts. 2008-03-20 02:56:24 +00:00
crypto Fix the Xlist so it actually works with 'tar -X', and update the upgrade 2008-02-06 23:14:24 +00:00
etc Be sure to run rc.d/zfs before mountcritremote. This way we can for example 2008-03-19 14:44:55 +00:00
games Fix typo. 2008-03-03 10:06:52 +00:00
gnu Re-enable the CVS build. 2008-03-19 15:21:44 +00:00
include Add cpu affinity APIs to get and set thread's cpu affinity mask, the 2008-03-03 08:28:13 +00:00
kerberos5
lib Use linker set to collection all target operations. 2008-03-22 05:40:44 +00:00
libexec For un-prototyped static inline functions declared in pthread_md.h on 2007-12-01 14:24:44 +00:00
release New release notes: cpuset, BTX real mode, gptboot (+MFC), BSD 2008-03-15 07:06:12 +00:00
rescue Add an alias for glabel(8). 2008-03-05 23:32:12 +00:00
sbin No need to be gratuitously style(9) non-compliant here, even though 2008-03-21 20:38:28 +00:00
secure For users of FreeBSD <= 6.2 we recommend during the x.org 7.x upgrade 2008-03-05 20:58:15 +00:00
share Oops, add back the SYNOPSIS section header I accidently removed in the 2008-03-20 08:46:27 +00:00
sys Fix a race where timeout/untimeout could cause crashes for Giant locked 2008-03-22 07:29:45 +00:00
tools Alert properly when we have stale mounts left after interupting 2008-03-20 12:56:49 +00:00
usr.bin Fix usage string. 2008-03-20 09:53:45 +00:00
usr.sbin Fix two bugs introduced in conversion to FreeBSD source tree: 2008-03-19 10:56:51 +00:00
COPYRIGHT Happy new year 2008! 2007-12-31 22:09:19 +00:00
LOCKS Once the release goes out, RELENG_7_* will need approval from so@. 2008-01-24 22:07:03 +00:00
MAINTAINERS OLDCARD is gone, release imp's lock. 2008-01-26 21:58:52 +00:00
Makefile Add a note pointing to build(7) for more info. 2008-01-30 19:33:18 +00:00
Makefile.inc1 Set AR=gnu-ar and RANLIB=gnu-ranlib on systems where we are forced 2008-03-02 11:10:46 +00:00
ObsoleteFiles.inc Add an include file from the removed XRPU driver. 2008-03-13 18:17:46 +00:00
README
UPDATING - Add an UPDATING entry about the removal of KSE. 2008-03-12 09:48:42 +00:00

This is the top level of the FreeBSD source directory.  This file
was last revised on:
$FreeBSD$

For copyright information, please see the file COPYRIGHT in this
directory (additional copyright information also exists for some
sources in this tree - please see the specific source directories for
more information).

The Makefile in this directory supports a number of targets for
building components (or all) of the FreeBSD source tree, the most
commonly used one being ``world'', which rebuilds and installs
everything in the FreeBSD system from the source tree except the
kernel, the kernel-modules and the contents of /etc.  The ``world''
target should only be used in cases where the source tree has not
changed from the currently running version.  See:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
for more information, including setting make(1) variables.

The ``buildkernel'' and ``installkernel'' targets build and install
the kernel and the modules (see below).  Please see the top of
the Makefile in this directory for more information on the
standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process, documentation
for which can be found at:
   http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html
And in the config(8) man page.
Note: If you want to build and install the kernel with the
``buildkernel'' and ``installkernel'' targets, you might need to build
world before.  More information is available in the handbook.

The sample kernel configuration files reside in the sys/<arch>/conf
sub-directory (assuming that you've installed the kernel sources), the
file named GENERIC being the one used to build your initial installation
kernel.  The file NOTES contains entries and documentation for all possible
devices, not just those commonly used.  It is the successor of the ancient
LINT file, but in contrast to LINT, it is not buildable as a kernel but a
pure reference and documentation file.


Source Roadmap:
---------------
bin		System/user commands.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

games		Amusements.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

sys		Kernel sources.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.


For information on synchronizing your source tree with one or more of
the FreeBSD Project's development branches, please see:

  http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html