mirror of
https://github.com/freebsd/freebsd-src.git
synced 2024-11-30 08:43:23 +00:00
6f9cba8f8b
Local changes: - In contrib/libpcap/pcap/bpf.h, do not include pcap/dlt.h. Our system net/dlt.h is pulled in from net/bpf.h. - sys/net/dlt.h: Incorporate changes from libpcap 1.10.3. - lib/libpcap/Makefile: Update for libpcap 1.10.3. Changelog: https://git.tcpdump.org/libpcap/blob/95691ebe7564afa3faa5c6ba0dbd17e351be455a:/CHANGES Reviewed by: emaste Obtained from: https://www.tcpdump.org/release/libpcap-1.10.3.tar.gz Sponsored by: The FreeBSD Foundation
34 lines
1.4 KiB
Plaintext
34 lines
1.4 KiB
Plaintext
TODO list for libpcap
|
|
=======================
|
|
|
|
Important stuff (to be done before the next release)
|
|
---------------
|
|
|
|
General
|
|
|
|
- configure should not be in Git. Most open source projects have an
|
|
autogen.sh script to run autoconf etc. after checkout. I think we
|
|
should stick to the standard.
|
|
|
|
- The source files should be better documented. There is no official
|
|
design guideline for what is done where. There should be a common coding
|
|
style (okay, you can guess that by looking at the code) and a guide for
|
|
what needs to be documented.
|
|
|
|
Less urgent items
|
|
-----------------
|
|
|
|
- Better documentation and cleanup of the interface. I am seeing a few
|
|
problems at the first glance which needs fixing:
|
|
+ pcap_lookupnet makes little to no sense with protocols != IPv4
|
|
+ not very well suited for interactive programs (think ethereal). There
|
|
should be a way for the application to get a file descriptor which it
|
|
has to monitor and a callback in pcap which has to be called on
|
|
activity (XXX - "pcap_fileno()" handles the first part, although
|
|
"select()" and "poll()" don't work on BPF devices on most BSDs, and
|
|
you can call "pcap_dispatch()" as the dispatch routine after putting
|
|
the descriptor into non-blocking mode)
|
|
+ too many functions. There are a lot of functions for everything which
|
|
violates the KISS principle. Why do we need pcap_strerror, pcap_perror
|
|
and pcap_geterr?
|