Go to file
John Baldwin b4c700fa7c new-bus: Fix some shortcomings in disabling devices via hints
A device can be disabled via a hint after it is probed (but before it
is attached).  The initial version of this marked the device disabled,
but left the device "alive" meaning that dev->driver and dev->desc
were untouched and still pointed into the driver that probed the
device.  If that driver lives in a kernel module that is later
unloaded, device_detach() called from devclass_delete_driver() doesn't
do anything (the device's state is DS_ALIVE).  In particular, it
doesn't call device_set_driver(dev, NULL) to disassociate the device
from the driver that is being unloaded.

There are several places where these stale pointers can be tripped
over.  After kldunload, invoking the sysctl to fetch device info can
dereference dev->desc and dev->driver causing panics.  Even without
kldunload, a system suspend request will call the device_suspend and
device_resume DEVMETHODs of the driver in question even though the
device is not attached which can cause some excitement.

To clean this up, more fully detach a device that is disabled by a
hint by clearing the driver and setting the state to DS_NOTPRESENT.
However, to keep the device name+unit combination reserved, leave the
device attached to its devclass.

This requires a change to 'devctl enable' handling to deal with this
updated state.  It now checks for a non-NULL devclass to determine if
a disabled device is in this state and if so it clears the hint.
However, it also now clears the devclass before attaching the device.
This gives all drivers an opportunity to attach to the now-enabled
device.

Reported by:	adrian
Discussed with:	imp
Reviewed by:	imp
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D47691
2024-11-23 11:39:02 -05:00
.cirrus-ci
.github CI: Automate some GitHub PR status labels manipulations 2024-11-04 17:16:32 -08:00
bin sh(1): -l is only valid in cli option not as set -l 2024-11-20 14:15:41 +01:00
cddl zfs: merge openzfs/zfs@1c9a4c8cb 2024-11-13 13:49:10 +01:00
contrib Merge llvm-project release/19.x llvmorg-19.1.4-0-gaadaa00de76e 2024-11-21 18:46:18 +01:00
crypto Canonicalize the name of the FreeBSD Foundation 2024-10-24 05:03:07 +08:00
etc include: Install dev/vmm headers 2024-11-05 01:40:41 +00:00
gnu
include lib/libc/string: apply SSP hardening and tests to memset_explicit 2024-11-14 23:10:00 +01:00
kerberos5
lib getentropy: restore unistd.h include 2024-11-22 13:08:41 -05:00
libexec nuageinit: add test about encrypted passwords 2024-11-20 11:02:55 +01:00
release release: Don't break if firmware install fails 2024-11-20 22:13:24 -08:00
rescue
sbin pfctl: clear statistic for specified addresses 2024-11-22 12:22:16 +01:00
secure manuals: Remove trailing spaces 2024-11-04 11:26:14 -04:00
share Add new kern.vt.slow_down tunable. 2024-11-23 15:01:09 +00:00
stand stand: drop inttypes.h from safe list 2024-11-20 12:49:48 -07:00
sys new-bus: Fix some shortcomings in disabling devices via hints 2024-11-23 11:39:02 -05:00
targets Retire MK_PROFILE infrastructure 2024-11-12 12:11:51 -05:00
tests pfctl: clear statistic for specified addresses 2024-11-22 12:22:16 +01:00
tools git-arc: Document how a reviewer group can be referenced 2024-11-21 10:36:50 +00:00
usr.bin ktrace: support AF_NETLINK in ktrstruct 2024-11-19 14:19:50 -08:00
usr.sbin newsyslog.conf(5): Accept human unit suffix in the size filed 2024-11-21 13:39:09 +08:00
.arcconfig
.arclint
.cirrus.yml Cirrus-CI: switch to FreeBSD 13.3 2024-11-01 21:52:04 -04:00
.clang-format
.git-blame-ignore-revs
.gitattributes
.gitignore
.mailmap
CONTRIBUTING.md
COPYRIGHT
LOCKS
MAINTAINERS
Makefile
Makefile.inc1 Retire MK_PROFILE infrastructure 2024-11-12 12:11:51 -05:00
Makefile.libcompat
Makefile.sys.inc
ObsoleteFiles.inc mv: Convert tests to ATF. 2024-11-19 10:29:11 +01:00
README.md
RELNOTES RELNOTES: Document that grep no longer follows symlinks by default 2024-11-13 12:10:39 -05:00
UPDATING rc: Remove rc_fast_and_loose 2024-10-28 22:10:49 +01:00

FreeBSD Source:

This is the top level of the FreeBSD source directory.

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), FreeBSD handbook on building userland, and Handbook for kernels for more information, including setting make(1) variables.

For information on the CPU architectures and platforms supported by FreeBSD, see the FreeBSD website's Platforms page.

For official FreeBSD bootable images, see the release page.

Source Roadmap:

Directory Description
bin System/user commands.
cddl Various commands and libraries under the Common Development and Distribution License.
contrib Packages contributed by 3rd parties.
crypto Cryptography stuff (see crypto/README).
etc Template files for /etc.
gnu Commands and libraries under the GNU General Public License (GPL) or Lesser General Public License (LGPL). Please see gnu/COPYING and gnu/COPYING.LIB for more information.
include System include files.
kerberos5 Kerberos5 (Heimdal) package.
lib System libraries.
libexec System daemons.
release Release building Makefile & associated tools.
rescue Build system for statically linked /rescue utilities.
sbin System commands.
secure Cryptographic libraries and commands.
share Shared resources.
stand Boot loader sources.
sys Kernel sources (see sys/README.md).
targets Support for experimental DIRDEPS_BUILD
tests Regression tests which can be run by Kyua. See tests/README for additional information.
tools Utilities for regression testing and miscellaneous tasks.
usr.bin User commands.
usr.sbin System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see FreeBSD Handbook.