diff --git a/src/WINNT/install/wix/custom/afscustom.cpp b/src/WINNT/install/wix/custom/afscustom.cpp index 3ea2c4a848..714e8531f2 100644 --- a/src/WINNT/install/wix/custom/afscustom.cpp +++ b/src/WINNT/install/wix/custom/afscustom.cpp @@ -576,7 +576,8 @@ do_reg_copy_value(MSIHANDLE hInstall, HKEY hk_src, HKEY hk_dest, const TCHAR * v rv = RegQueryValueEx(hk_src, value, 0, &type, buffer, &cb); if (rv == ERROR_MORE_DATA) { - buffer = new BYTE[cb]; + // Some types require space for a terminating NUL which might not be present + buffer = new BYTE[++cb]; if (buffer == NULL) { ShowMsiActionData(hInstall, _T("Out of memory")); return; @@ -827,6 +828,11 @@ SetAfscredsOptionsFromRegValue(MSIHANDLE hInstall, HKEY hk) // MSIDLLEXPORT DetectSavedConfiguration( MSIHANDLE hInstall ) { + // Attempt a backup. If there is something to save, it will be. + // If not, nothing has changed. + // + BackupAFSClientRegistryKeys( hInstall ); + { MSIHANDLE hRec; diff --git a/src/WINNT/install/wix/lang/en_US/ui.wxi b/src/WINNT/install/wix/lang/en_US/ui.wxi index cd12f7b71d..a52ef617c2 100644 --- a/src/WINNT/install/wix/lang/en_US/ui.wxi +++ b/src/WINNT/install/wix/lang/en_US/ui.wxi @@ -780,18 +780,18 @@ - Configuration settings from a prior OpenAFS installation is available. + Configuration settings from a previous OpenAFS installation are available. - [DlgTitleFont]Restore configuration? + [DlgTitleFont]Preserve configuration? Specify new settings. Basic settings can be set via this installer. All others will be reset to defaults. - Restore and use the saved configuration settings. + Use the existing or saved configuration.