From 0a896b93c86e86f5b438880ef1634b4e39ee5779 Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Fri, 13 Mar 2015 10:33:05 -0500 Subject: [PATCH] Do not set default AFS_SYSCALL Currently, afs_args.h will define an AFS_SYSCALL value by default (31) if the current platform does not define an AFS_SYSCALL value on its own (via its param.h info). This is dangerous, since if a platform does not define an AFS_SYSCALL, or if it happens to not be defined for any reason, some code may try to call syscall 31, which could be anything. So get rid of this. If this breaks the build on any platform, then that platform should define AFS_SYSCALL in its own platform-specific header, or get rid of the problematic AFS_SYSCALL usage. Change-Id: I9583c8e5adc4106848a437d81306000490787ef3 Reviewed-on: https://gerrit.openafs.org/11938 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot --- src/config/afs_args.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/config/afs_args.h b/src/config/afs_args.h index 4fa286ba34..5d508a3f6d 100644 --- a/src/config/afs_args.h +++ b/src/config/afs_args.h @@ -125,11 +125,6 @@ #define AFSCALL_RXSTATS_DISABLE 0x2 /* Disable RX stats */ #define AFSCALL_RXSTATS_CLEAR 0x4 /* Clear RX stats */ -/* Main afs syscall entry; this number may vary per system (i.e. defined in afs/param.h) */ -#ifndef AFS_SYSCALL -#define AFS_SYSCALL 31 -#endif - /* arguments passed by afsd */ #define IDTYPE_UID 0