jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-22 17:00:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

afsdb-avoid-dns-case-issues-for-cell-aliases-20011106

Browse Source 
This patch makes sure that in-kernel aliases to non-existant names aren't
  accidentally created due to case mismatch (e.g. "athena" being created as
  a symlink to "athena.MIT.EDU", while "athena.mit.edu" is the real cell
  that already exists).  It also lowercases cell names in AFSDB lookups,
  otherwise the same problem appears in userspace (eg "aklog athena" tries
  to obtain tokens for cell "athena.MIT.EDU").
This commit is contained in:
Nickolai Zeldovich 2001-11-07 00:01:52 +00:00 committed by Derrick Brashear
parent 547ce13327
commit 0d4fd9fd66
2 changed files with 38 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/afs/afs_cell.c
View File

@ -220,17 +220,18 @@ int afs_GetCellHostsFromDns(acellName, acellHosts, timeout, realName)
}
void afs_RefreshCell(tc)
register struct cell *tc;
void afs_RefreshCell(ac)
register struct cell *ac;
{
afs_int32 cellHosts[MAXCELLHOSTS];
char *realName = NULL;
struct cell *tc;
int timeout;
/* Don't need to do anything if no timeout or it's not expired */
if (!tc->timeout || tc->timeout > osi_Time()) return;
if (!ac->timeout || ac->timeout > osi_Time()) return;
if (afs_GetCellHostsFromDns(tc->cellName, cellHosts, &timeout, &realName))
if (afs_GetCellHostsFromDns(ac->cellName, cellHosts, &timeout, &realName))
/* In case of lookup failure, keep old data */
goto done;
@ -238,9 +239,19 @@ void afs_RefreshCell(tc)
afs_NewCell(realName, cellHosts, 0, (char *) 0, 0, 0, timeout, (char *) 0);
/* If this is an alias, update the alias entry too */
if (afs_strcasecmp(tc->cellName, realName))
afs_NewCell(tc->cellName, 0, CAlias, (char *) 0, 0, 0,
timeout, realName);
if (afs_strcasecmp(ac->cellName, realName)) {
/*
* Look up the entry we just updated, to compensate for
* uppercase-vs-lowercase lossage with DNS.
*/
tc = afs_GetCellByName2(realName, READ_LOCK, 0 /* no AFSDB */);
if (tc) {
afs_NewCell(ac->cellName, 0, CAlias, (char *) 0, 0, 0,
timeout, tc->cellName);
afs_PutCell(tc, READ_LOCK);
}
}
done:
if (realName)
@ -254,6 +265,7 @@ struct cell *afs_GetCellByName_Dns(acellName, locktype)
{
afs_int32 cellHosts[MAXCELLHOSTS];
char *realName = NULL;
struct cell *tc;
int timeout;
if (afs_GetCellHostsFromDns(acellName, cellHosts, &timeout, &realName))
@ -264,9 +276,21 @@ struct cell *afs_GetCellByName_Dns(acellName, locktype)
/* If this is an alias, create an entry for it too */
if (afs_strcasecmp(acellName, realName)) {
if (afs_NewCell(acellName, 0, CAlias, (char *) 0, 0, 0,
timeout, realName))
/*
* Look up the entry we just updated, to compensate for
* uppercase-vs-lowercase lossage with DNS.
*/
tc = afs_GetCellByName2(realName, READ_LOCK, 0 /* no AFSDB */);
if (!tc)
goto bad;
if (afs_NewCell(acellName, 0, CAlias, (char *) 0, 0, 0,
timeout, tc->cellName)) {
afs_PutCell(tc, READ_LOCK);
goto bad;
}
afs_PutCell(tc, READ_LOCK);
}
if (realName)

5
src/auth/cellconfig.c
View File

@ -718,6 +718,11 @@ afsconf_GetAfsdbInfo(acellName, aservice, acellInfo)
if (server_num == 0) /* No AFSDB records */
return AFSCONF_NOTFOUND;
/* Convert the real cell name to lowercase */
for (p = (unsigned char *) realCellName; *p; p++)
*p = tolower(*p);
strncpy(acellInfo->name, realCellName, sizeof(acellInfo->name));
acellInfo->numServers = server_num;