jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 23:40:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

windows-checkVCs-20081015

Browse Source 
LICENSE MIT
FIXES 116641

Do not drop references to 'nextp' until we are done with the object.
Dropping the last reference can result in the object being destroyed.
This commit is contained in:
Jeffrey Altman 2008-10-15 14:50:51 +00:00
parent 9be6b92a17
commit 1115e29dac
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/WINNT/afsd/smb.c
View File

@ -3752,14 +3752,24 @@ void smb_CheckVCs(void)
osi_panic("afsd: invalid smb_vc_t detected in smb_allVCsp",
__FILE__, __LINE__);
/* on the first pass hold 'vcp' which was not held as 'nextp' */
if (vcp != nextp)
smb_HoldVCNoLock(vcp);
/*
* obtain a reference to 'nextp' now because we drop the
* smb_rctLock later and the list contents could change
* or 'vcp' could be destroyed when released.
*/
nextp = vcp->nextp;
if (vcp->flags & SMB_VCFLAG_ALREADYDEAD)
continue;
smb_HoldVCNoLock(vcp);
if (nextp)
smb_HoldVCNoLock(nextp);
if (vcp->flags & SMB_VCFLAG_ALREADYDEAD) {
smb_ReleaseVCNoLock(vcp);
continue;
}
smb_FormatResponsePacket(vcp, NULL, outp);
smbp = (smb_t *)outp;
outp->inCom = smbp->com = 0x2b /* Echo */;
@ -3778,8 +3788,6 @@ void smb_CheckVCs(void)
lock_ObtainWrite(&smb_rctLock);
smb_ReleaseVCNoLock(vcp);
if (nextp)
smb_ReleaseVCNoLock(nextp);
}
lock_ReleaseWrite(&smb_rctLock);
smb_FreePacket(outp);