jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

build: Repair 'make pristine' target

Browse Source 
Commit c66971ce4279e8840803d67bd935b5df080a0fbe 'man-pages: Generate man
pages with Pod::Man' inadvertently broke the top-level Makefile.in
'pristine:' rule.

This leads to the following error with 'make pristine':
  ...
  doc/man-pages/man5 \
  doc/man-pages/man8 \
  for i in doc/man-pages/pod*/*.pod.in; do \
      /bin/rm -f ${i%.in}; \
  done
  sh: syntax error at line 15: `do' unexpected
  *** Error code 3
  make: Fatal error: Command failed for target `pristine'

Remove the stray line continuation so the pod file deletion script will
work properly.

Additionally, the doc/man-pages/man* file objects are directories;
therefore the existing pristine rule 'rm -f' command will fail to remove
them:
  ...
  doc/xml/mobi-fixup.xsl \
  doc/man-pages/man1 \
  doc/man-pages/man3 \
  doc/man-pages/man5 \
  doc/man-pages/man8
  rm: doc/man-pages/man1 is a directory
  rm: doc/man-pages/man3 is a directory
  rm: doc/man-pages/man5 is a directory
  rm: doc/man-pages/man8 is a directory
  *** Error code 2
  make: Fatal error: Command failed for target `pristine'

Reinstate the former 'rm -rf' command so the man-pages/man* directories
will also be properly erased.

Change-Id: I11658de0c02679d6c4b57917949cf2a70c9c019f
Reviewed-on: https://gerrit.openafs.org/15782
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
This commit is contained in:
Mark Vitale 2024-07-10 14:55:43 -04:00 committed by Michael Meffie
parent d8556405c3
commit 159bd949a4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Makefile.in
View File

@ -955,11 +955,11 @@ pristine: distclean
src/cf/ltsugar.m4 \
src/cf/ltversion.m4 \
src/cf/lt~obsolete.m4 \
doc/xml/mobi-fixup.xsl \
doc/man-pages/man1 \
doc/xml/mobi-fixup.xsl
/bin/rm -rf doc/man-pages/man1 \
doc/man-pages/man3 \
doc/man-pages/man5 \
doc/man-pages/man8 \
doc/man-pages/man8
for i in doc/man-pages/pod*/*.pod.in; do \
/bin/rm -f $${i%.in}; \
done