jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Restore max() macro for Heimdal

Browse Source 
Commit de46edef693d (Remove lowercase min/max macro definitions)
inadvertently removed a definition of max() that is required by
_krb5_n_fold() (src/external/heimdal/krb5/n-fold.c) if no system
definition of max() is available.  For example, on Solaris this results
in a kernel module with an undefined external symbol 'max', which
prevents the kernel module from loading:

  genunix: [ID 819705 kern.notice] /kernel/drv/amd64/afs: undefined symbol
  genunix: [ID 826211 kern.notice]  'max'
  genunix: [ID 472681 kern.notice] WARNING: mod_load: cannot load module 'afs'

Restore the required max() macro definition.

Change-Id: I6bca2bb2b90d7cdbe90a3b769997cdc153f59f6c
Reviewed-on: https://gerrit.openafs.org/15874
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
This commit is contained in:
Mark Vitale 2024-11-04 12:39:32 -05:00 committed by Andrew Deason
parent d93871b054
commit 21491d9a82
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/crypto/rfc3961/krb5_locl.h
View File

@ -66,6 +66,10 @@
#define ALLOC(X, N) (X) = calloc((N), sizeof(*(X))) #define ALLOC(X, N) (X) = calloc((N), sizeof(*(X)))
#ifndef max
#define max(a,b) (((a)>(b))?(a):(b))
#endif
#ifndef O_BINARY #ifndef O_BINARY
#define O_BINARY 0 #define O_BINARY 0
#endif #endif