From 220336585530ff9f0b4b1e3b47e3dd6727a18ab3 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Tue, 26 Feb 2013 11:52:01 +0000 Subject: [PATCH] libafscp: NULL return value not pointer When afscp_FindCallBack sets its return-by-reference value to NULL, it should do so to the value itself, not the pointer to it. Caught by coverity (#988419) Reviewed-on: http://gerrit.openafs.org/9266 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear (cherry picked from commit 99929488511d13dab94491cac1d477062f9da741) Change-Id: I046189684cef6c88c46455a90ab49d03da1f1cab Reviewed-on: http://gerrit.openafs.org/9359 Tested-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear --- src/libafscp/afscp_callback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libafscp/afscp_callback.c b/src/libafscp/afscp_callback.c index e1f13d7948..3bb8062821 100644 --- a/src/libafscp/afscp_callback.c +++ b/src/libafscp/afscp_callback.c @@ -112,7 +112,7 @@ afscp_FindCallBack(const struct afscp_venusfid *f, time_t now; struct afscp_venusfid fid; - ret = NULL; + *ret = NULL; time(&now); for (i = 0; i < afscp_maxcallbacks; i++) {