From 244b82d24c37355bc855361815a7e682d6445af3 Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Sun, 14 Dec 2014 16:13:39 -0500 Subject: [PATCH] rx: Tidy up rxi_CheckCall()'s mtuout handling We don't actually do anything that matters if lastPacketSizeSeq is set and lastPacketSize is zero, so zero both when we're cleaning up. lastPacketSize and lastPacketSizeSeq are set together in rxi_SendPacket (and rxi_SendPacketList), when we are sending a packet larger than the current estimate of the peer's maxPacketSize. The two fields are checked together during ack processing, but rxi_CheckCall() only checks lastPacketSize, ignoring lastPacketSizeSeq. Change-Id: I4e52bed0900b5551859200699f114f5d5a61581c Reviewed-on: http://gerrit.openafs.org/11633 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot Reviewed-by: Daria Brashear --- src/rx/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rx/rx.c b/src/rx/rx.c index 611ca1dd6a..c90a27141c 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -6308,7 +6308,7 @@ mtuout: rxi_SetPeerMtu(conn->peer, 0, 0, newmtu); /* clean up */ - conn->lastPacketSize = 0; + conn->lastPacketSize = conn->lastPacketSizeSeq = 0; /* needed so ResetCall doesn't clobber us. */ call->MTU = conn->peer->ifMTU;