jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-02-01 05:57:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libafs: Fix second pass in ShakeLooseVCaches

Browse Source 
Commit 3105c7ff introduced a two phase process for reclaiming
vcache entries.  First go through the list and do what's possible
without sleeping (skipping aliased dentries on Linux), then do
a second pass only if necessary, allowing sleeping.

Unfortunately the test for the end of the VLRU scan is incorrect
and can never trigger, so this second pass was effectively disabled
and any code that is conditional on defersleep=1 was never
exercised.  The code to start the second scan also has issues.

Fix the end of VLRU test, and also correctly set the variables
needed to restart the scan.

Change-Id: I8034cd3b79aab4f2976ab2559c13c102126480d7
Reviewed-on: http://gerrit.openafs.org/8234
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit a7828d50a82384e6d0fb0ad5b5a702f768029581)
Reviewed-on: http://gerrit.openafs.org/8247
This commit is contained in:
Marc Dionne 2012-10-12 16:31:24 -04:00 committed by Derrick Brashear
parent 0506af9c05
commit 2aab481dfa
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/afs/afs_vcache.c
View File

@ -690,10 +690,11 @@ afs_ShakeLooseVCaches(afs_int32 anumber)
i = 0;
continue; /* start over - may have raced. */
}
if (tq == uq) {
if (uq == &VLRU) {
if (anumber && !defersleep) {
defersleep = 1;
tq = VLRU.prev;
uq = VLRU.prev;
i = 0;
continue;
}
break;