From 2b4908d3be8c4bde135d836ccc4ca96e465628c3 Mon Sep 17 00:00:00 2001 From: Mark Vitale Date: Thu, 23 Apr 2020 17:49:20 -0400 Subject: [PATCH] afs: fix afs_linux_mmap fstrace entry The format string for CM_TRACE_GMAP takes 4 substitutions, but afs_linux_mmap only supplies 3. This results in malformed output from fstrace: Type mismatch, using raw print. Gn_map vp 0x%lx addr 0x%lx len 0x%x off 0x%x (afs / zcm)raw op 701087775, time 715.322573, pid 9644 p0:0xc0a66ec0 p1:0x8b81a000 p2:131072 Repair the recording of CM_TRACE_GMAP. Change-Id: I2b7592e68cb42f5ae490ee8771558e5cc5a2181e Reviewed-on: https://gerrit.openafs.org/14168 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- src/afs/LINUX/osi_vnodeops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/afs/LINUX/osi_vnodeops.c b/src/afs/LINUX/osi_vnodeops.c index 7291e9ed96..4617a34bab 100644 --- a/src/afs/LINUX/osi_vnodeops.c +++ b/src/afs/LINUX/osi_vnodeops.c @@ -533,9 +533,9 @@ afs_linux_mmap(struct file *fp, struct vm_area_struct *vmap) int code; AFS_GLOCK(); - afs_Trace3(afs_iclSetp, CM_TRACE_GMAP, ICL_TYPE_POINTER, vcp, - ICL_TYPE_POINTER, vmap->vm_start, ICL_TYPE_INT32, - vmap->vm_end - vmap->vm_start); + afs_Trace4(afs_iclSetp, CM_TRACE_GMAP, ICL_TYPE_POINTER, vcp, + ICL_TYPE_POINTER, vmap->vm_start, ICL_TYPE_LONG, + vmap->vm_end - vmap->vm_start, ICL_TYPE_LONG, 0); /* get a validated vcache entry */ code = afs_linux_VerifyVCache(vcp, NULL);