jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-21 08:20:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows: do not bugcheck in AFSExAllocatePoolWithTag

Browse Source 
If the Bug Check flag is set, the call to AFSBreakPoint() in
AFSExAllocatePoolWithTag() will trigger.  There is no need for
an explicit bug check test in AFSExAllocatePoolWithTag().

If AFSExAllocatePoolWithTag() returns NULL there is no need
to ASSERT() the return value since AFSBreakPoint() would already
have been called to signal a debugger.

Change-Id: Ie8564f41f811c3afd99dc2e9c02f4aa68d63ef8e
Reviewed-on: http://gerrit.openafs.org/6780
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
This commit is contained in:
Jeffrey Altman 2012-02-23 06:31:31 -08:00 committed by Jeffrey Altman
parent fe6cc80fdb
commit 315b97ab58
2 changed files with 14 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/WINNT/afsrdr/kernel/fs/AFSGeneric.cpp
View File

@ -1317,32 +1317,23 @@ AFSExAllocatePoolWithTag( IN POOL_TYPE PoolType,
if( pBuffer == NULL)
{
if( BooleanFlagOn( AFSDebugFlags, AFS_DBG_BUGCHECK_EXCEPTION))
{
AFSDbgLogMsg( 0,
0,
"AFSExAllocatePoolWithTag failure Type %08lX Size %08lX Tag %08lX %08lX\n",
PoolType,
NumberOfBytes,
Tag,
PsGetCurrentThread());
KeBugCheck( (ULONG)-2);
}
else
{
switch ( Tag ) {
AFSDbgLogMsg( 0,
0,
"AFSExAllocatePoolWithTag failure Type %08lX Size %08lX Tag %08lX %08lX\n",
PoolType,
NumberOfBytes,
Tag,
PsGetCurrentThread());
case AFS_GENERIC_MEMORY_21_TAG:
case AFS_GENERIC_MEMORY_22_TAG:
// AFSDumpTraceFiles -- do nothing;
break;
switch ( Tag ) {
case AFS_GENERIC_MEMORY_21_TAG:
case AFS_GENERIC_MEMORY_22_TAG:
// AFSDumpTraceFiles -- do nothing;
break;
default:
AFSBreakPoint();
}
default:
AFSBreakPoint();
}
}

2
src/WINNT/afsrdr/kernel/lib/AFSExtentsSupport.cpp
View File

@ -1014,8 +1014,6 @@ AFSProcessExtentsResult( IN AFSFcb *Fcb,
if (NULL == pExtent)
{
ASSERT( FALSE);
try_return (ntStatus = STATUS_INSUFFICIENT_RESOURCES );
}