jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 13:38:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows: Avoid race during PIOCtl DirNode allocation

Browse Source 
Use InterlockedCompareExchangePointer to assign the DirNode to
ObjectInfo->Specific.Directory.PIOCtlDirectoryCB.  Otherwise,
one thread could race with another thread when allocating the
pioctl object.

Change-Id: Ic5b1a0ff2e44f2c4520cc7f5e536bd876bc83a65
Reviewed-on: http://gerrit.openafs.org/6661
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
This commit is contained in:
Jeffrey Altman 2012-02-04 17:26:02 -05:00 committed by Jeffrey Altman
parent b819d3e3ab
commit 39d152810d
1 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp
View File

@ -5552,6 +5552,7 @@ AFSInitPIOCtlDirectoryCB( IN AFSObjectInfoCB *ObjectInfo)
AFSDirectoryCB *pDirNode = NULL; AFSDirectoryCB *pDirNode = NULL;
ULONG ulEntryLength = 0; ULONG ulEntryLength = 0;
AFSNonPagedDirectoryCB *pNonPagedDirEntry = NULL; AFSNonPagedDirectoryCB *pNonPagedDirEntry = NULL;
LONG lCount;
__Enter __Enter
{ {
@ -5633,11 +5634,33 @@ AFSInitPIOCtlDirectoryCB( IN AFSObjectInfoCB *ObjectInfo)
pDirNode->CaseInsensitiveTreeEntry.HashIndex = AFSGenerateCRC( &pDirNode->NameInformation.FileName, pDirNode->CaseInsensitiveTreeEntry.HashIndex = AFSGenerateCRC( &pDirNode->NameInformation.FileName,
TRUE); TRUE);
ObjectInfo->Specific.Directory.PIOCtlDirectoryCB = pDirNode; if ( InterlockedCompareExchangePointer( (PVOID *)&ObjectInfo->Specific.Directory.PIOCtlDirectoryCB, pDirNode, NULL) != NULL)
{
AFSDbgLogMsg( AFS_SUBSYSTEM_FILE_PROCESSING,
AFS_TRACE_LEVEL_WARNING,
"AFSInitPIOCtlDirectoryCB Raced PIOCtlDirectoryCB %08lX pFcb %08lX\n",
ObjectInfo->Specific.Directory.PIOCtlDirectoryCB,
pDirNode);
//
// Increment the open reference and handle on the node
//
lCount = InterlockedIncrement( &pDirNode->ObjectInformation->ObjectReferenceCount);
AFSDbgLogMsg( AFS_SUBSYSTEM_FCB_REF_COUNTING,
AFS_TRACE_LEVEL_VERBOSE,
"AFSInitPIOCtlDirectoryCB Increment count on Object %08lX Cnt %d\n",
pDirNode->ObjectInformation,
lCount);
try_return( ntStatus = STATUS_REPARSE);
}
try_exit: try_exit:
if ( !NT_SUCCESS( ntStatus)) if ( ntStatus != STATUS_SUCCESS)
{ {
if ( pDirNode != NULL) if ( pDirNode != NULL)