jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-21 08:20:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows: avoid deadlock TreeLock vs Fcb Resource

Browse Source 
Cannot call AFSPerformObjectInvalidate directly because
ObjectInfoCB->Specific.Directory.DirectoryNodeHdr.TreeLock is
held during the sequence

  AFSVerifyEntry->AFSValidateDirectoryCache->AFSVerifyDirectoryContent

and AFSPerformObjectInvalidate requires the Fcb->NPFcb->Resource
which must be held prior to the TreeLock.

Change-Id: I337f52e2927c8e5ae2d218867987625c3240a792
Reviewed-on: http://gerrit.openafs.org/7423
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
This commit is contained in:
Jeffrey Altman 2012-05-18 16:31:19 -04:00 committed by Jeffrey Altman
parent 564c9733e5
commit 3a7dbe3315
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
View File

@ -1070,12 +1070,22 @@ AFSVerifyDirectoryContent( IN AFSObjectInfoCB *ObjectInfoCB,
// //
// The ObjectReferenceCount will be freed by AFSPerformObjectInvalidate // The ObjectReferenceCount will be freed by AFSPerformObjectInvalidate
// if successfully queued. Cannot call AFSPerformObjectInvalidate directly
// because ObjectInfoCB->Specific.Directory.DirectoryNodeHdr.TreeLock is
// held during the sequence AFSVerifyEntry->AFSValidateDirectoryCache->
// AFSVerifyDirectoryContent and AFSPerformObjectInvalidate requires the
// Fcb->NPFcb->Resource which must be held prior to the TreeLock in the
// lock hierarchy.
// //
lCount = InterlockedIncrement( &pObjectInfo->ObjectReferenceCount); lCount = InterlockedIncrement( &pObjectInfo->ObjectReferenceCount);
AFSPerformObjectInvalidate( pObjectInfo, if ( !NT_SUCCESS( AFSQueueInvalidateObject( pObjectInfo,
AFS_INVALIDATE_DATA_VERSION); AFS_INVALIDATE_DATA_VERSION)))
{
lCount = InterlockedDecrement( &pObjectInfo->ObjectReferenceCount);
}
} }
else else
{ {