jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 23:10:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

afsmonitor: Fix multiple NUM_CM_STAT_ENTRIES overflows

Browse Source 
If an array is n elements long, accessing element array[n] is an
overflow. Fix various places where we apply loop bounds incorrectly
using the NUM_CM_STAT_ENTRIES constant.

Caught by coverity (#985571, #985573)

Change-Id: I24a53e8044d3d5d39d070909400329a82f22b6b9
Reviewed-on: http://gerrit.openafs.org/9316
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
This commit is contained in:
Simon Wilkinson 2013-02-28 17:14:20 +00:00 committed by Jeffrey Altman
parent 4ea1c8440a
commit 3beca62928
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/afsmonitor/afsmonitor.c
View File

@ -1299,8 +1299,8 @@ parse_showEntry(char *a_line)
if (strcasestr(arg2, "_group") != NULL) {
if (fromIdx < 0 || toIdx < 0 || fromIdx > NUM_CM_STAT_ENTRIES
|| toIdx > NUM_CM_STAT_ENTRIES)
if (fromIdx < 0 || toIdx < 0 || fromIdx >= NUM_CM_STAT_ENTRIES
|| toIdx >= NUM_CM_STAT_ENTRIES)
return (-10);
for (j = fromIdx; j <= toIdx; j++) {
if (!cm_showFlags[j]) {
@ -1308,7 +1308,7 @@ parse_showEntry(char *a_line)
cm_DisplayItems_count++;
cm_showFlags[j] = 1;
}
if (cm_DisplayItems_count > NUM_CM_STAT_ENTRIES) {
if (cm_DisplayItems_count >= NUM_CM_STAT_ENTRIES) {
fprintf(stderr, "[ %s ] cm_DisplayItems_count ovf\n", rn);
return (-11);
}
@ -1327,8 +1327,8 @@ parse_showEntry(char *a_line)
if (strcasestr(catName, "_group") != NULL) {
if (fromIdx < 0 || toIdx < 0
|| fromIdx > NUM_CM_STAT_ENTRIES
|| toIdx > NUM_CM_STAT_ENTRIES)
|| fromIdx >= NUM_CM_STAT_ENTRIES
|| toIdx >= NUM_CM_STAT_ENTRIES)
return (-12);
for (j = fromIdx; j <= toIdx; j++) {
if (!cm_showFlags[j]) {
@ -1336,7 +1336,7 @@ parse_showEntry(char *a_line)
cm_DisplayItems_count++;
cm_showFlags[j] = 1;
}
if (cm_DisplayItems_count > NUM_CM_STAT_ENTRIES) {
if (cm_DisplayItems_count >= NUM_CM_STAT_ENTRIES) {
fprintf(stderr,
"[ %s ] cm_DisplayItems_count ovf\n", rn);
return (-13);