jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-22 17:00:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rx-avoid-unnecessary-wakeups-20011225

Browse Source 
"This fixes a livelock condition introduced in my earlier
  resource starvation patch; apparently I had erred too far
  on the side of "wake up just in case".  The livelock bug
  is exhibited when running 10 fsstress processes at once;
  if many processes are waiting for a new Rx call, they get
  stuck in an uninterruptible kernel loop waking each other
  up."
This commit is contained in:
Nickolai Zeldovich 2001-12-25 18:13:20 +00:00 committed by Derrick Brashear
parent 28eefd7613
commit 3ea10ea353
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/rx/rx.c
View File

@ -1053,17 +1053,16 @@ struct rx_call *rx_NewCall(conn)
osi_rxSleep(conn);
#endif
conn->makeCallWaiters--;
/*
* Wake up anyone else who might be giving us a chance to
* run (see code above that avoids resource starvation).
*/
#ifdef RX_ENABLE_LOCKS
CV_BROADCAST(&conn->conn_call_cv);
#else
osi_rxWakeup(conn);
#endif
}
/*
* Wake up anyone else who might be giving us a chance to
* run (see code above that avoids resource starvation).
*/
#ifdef RX_ENABLE_LOCKS
CV_BROADCAST(&conn->conn_call_cv);
#else
osi_rxWakeup(conn);
#endif
CALL_HOLD(call, RX_CALL_REFCOUNT_BEGIN);