jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 23:10:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

drop afs_xserver lock during GetCapabilities

Browse Source 
new contact to a fileserver can trigger an InitCallBackStateN RPC
to us, which our agent will need afs_xserver to handle. don't hold it;
we only need it to fill in capabilities. racing here is ok.

Change-Id: Ie0aaea3ab462e421bd31ba3b703d8cd0cb0d61df
Reviewed-on: http://gerrit.openafs.org/1754
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Derrick Brashear 2010-04-14 18:33:47 -04:00
parent 55a24ddd42
commit 3f101a9ef4
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/afs/afs_server.c
View File

@ -1703,12 +1703,18 @@ afs_GetCapabilities(struct server *ts)
SHARED_LOCK);
if ( !tc )
return;
/* InitCallBackStateN, triggered by our RPC, may need this */
ReleaseWriteLock(&afs_xserver);
code = RXAFS_GetCapabilities(tc->id, &caps);
if ( code && code != RXGEN_OPCODE )
afs_warn("RXAFS_GetCapabilities failed with code %d\n", code);
else
ts->flags |= SCAPS_KNOWN;
ObtainWriteLock(&afs_xserver, 723);
afs_PutConn(tc, SHARED_LOCK);
if ( code && code != RXGEN_OPCODE ) {
afs_warn("RXAFS_GetCapabilities failed with code %d\n", code);
/* better not be anything to free. we failed! */
return;
}
ts->flags |= SCAPS_KNOWN;
if ( caps.Capabilities_len > 0 ) {
ts->capabilities = caps.Capabilities_val[0];
@ -1919,10 +1925,11 @@ afs_GetServer(afs_uint32 * aserverp, afs_int32 nservers, afs_int32 acell,
afs_stats_cmperf.srvRecordsHWM = afs_stats_cmperf.srvRecords;
}
ReleaseWriteLock(&afs_xsrvAddr);
if ( aport == AFS_FSPORT && !(newts->flags & SCAPS_KNOWN))
afs_GetCapabilities(newts);
ReleaseWriteLock(&afs_xsrvAddr);
ReleaseWriteLock(&afs_xserver);
return (newts);
} /* afs_GetServer */