jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ubik: remove unused code

Browse Source 
ubik_GetVersion and ubik_WaitVersion have been unused since at least
OpenAFS 1.0.  Remove them.

No functional change should be incurred by this commit.

Change-Id: Iee6952f35d8c34e9f05a4e6011f5795f7222fb08
Reviewed-on: https://gerrit.openafs.org/13325
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
This commit is contained in:
Mark Vitale 2016-11-09 16:58:00 -05:00 committed by Benjamin Kaduk
parent 809ee49b80
commit 3fae4ea19a
4 changed files with 0 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
doc/txt/ubik.txt
View File

@ -90,14 +90,6 @@ MAJOR DATA STRUCTURES
thread to examine them without holding the database lock; see the
section on the BEACON package for details.
The condition variable 'version_cond' is used to signal to that the
database version may have changed; it is broadcast in udisk_commit(),
in SDISK_SendFile(), and from the recovery thread; it is monitored by
ubik_WaitVersion(), which can be called by an application to wait for
a database version change (this is not currently used in OpenAFS).
This CV is associated with the database lock. When LWP is used, this
condition is signalled on &ubik_dbase->version.
The condition variable 'flags_cond' is used by udisk_end() to signal
that DBWRITING flag has been cleared. This wakes threads waiting in
ubik.c:BeginTrans() to begin a new transaction. This CV is
@ -1165,12 +1157,6 @@ MAJOR SUBSYSTEMS
Utilities
The functions ubik_GetVersion() and ubik_WaitVersion() provide the
application with a way to discover the current database version
and to wait for it to change. These interfaces are not currently
used in OpenAFS. ubik_GetVersion() needs to acquire the database
lock while copying the database version.
The internal function ubikGetPrimaryInterfaceAddr() is used by
Ubik RPCs to determine a peer server's primary address, given the
IP address from which a call arrived. This needs to hold the

15
src/ptserver/ptubik.c
View File

@ -92,13 +92,6 @@ ubik_SetLock(struct ubik_trans *atrans, afs_int32 apos, afs_int32 alen,
return (0);
}
int
ubik_WaitVersion(struct ubik_dbase *adatabase,
struct ubik_version *aversion)
{
return (0);
}
int
ubik_CheckCache(struct ubik_trans *atrans, ubik_updatecache_func cbf, void *rock)
{
@ -119,14 +112,6 @@ panic(char *format, ...)
AFS_UNREACHED(exit(1)); /* never know, though */
}
int
ubik_GetVersion(struct ubik_trans *dummy, struct ubik_version *ver)
{
memset(ver, 0, sizeof(struct ubik_version));
return (0);
}
int
ubik_Seek(struct ubik_trans *tt, afs_int32 afd, afs_int32 pos)
{

37
src/ubik/ubik.c
View File

@ -1254,43 +1254,6 @@ ubik_SetLock(struct ubik_trans *atrans, afs_int32 apos, afs_int32 alen,
return error;
}
/*!
* \brief utility to wait for a version # to change
*/
int
ubik_WaitVersion(struct ubik_dbase *adatabase,
struct ubik_version *aversion)
{
DBHOLD(adatabase);
while (1) {
/* wait until version # changes, and then return */
if (vcmp(*aversion, adatabase->version) != 0) {
DBRELE(adatabase);
return 0;
}
#ifdef AFS_PTHREAD_ENV
opr_cv_wait(&adatabase->version_cond, &adatabase->versionLock);
#else
DBRELE(adatabase);
LWP_WaitProcess(&adatabase->version); /* same vers, just wait */
DBHOLD(adatabase);
#endif
}
}
/*!
* \brief utility to get the version of the dbase a transaction is dealing with
*/
int
ubik_GetVersion(struct ubik_trans *atrans,
struct ubik_version *avers)
{
DBHOLD(atrans->dbase);
*avers = atrans->dbase->version;
DBRELE(atrans->dbase);
return 0;
}
/*!
* \brief Facility to simplify database caching.
* \return zero if last trans was done on the local server and was successful.

4
src/ubik/ubik.p.h
View File

@ -572,10 +572,6 @@ extern int ubik_Truncate(struct ubik_trans *transPtr,
afs_int32 length);
extern int ubik_SetLock(struct ubik_trans *atrans, afs_int32 apos,
afs_int32 alen, int atype);
extern int ubik_WaitVersion(struct ubik_dbase *adatabase,
struct ubik_version *aversion);
extern int ubik_GetVersion(struct ubik_trans *atrans,
struct ubik_version *avers);
extern int ubik_CheckCache(struct ubik_trans *atrans,
ubik_updatecache_func check,
void *rock);