From 40291c76c3fa95394ebaef05a3b6cc2fa3d8d192 Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Thu, 12 Aug 2010 14:38:55 -0500 Subject: [PATCH] libafs: Set tvcp->callback before BulkStatus When we call InlineBulkStatus or BulkStatus, we currently do not touch tvcp->callback for any of the vcaches before making the call. This can cause us to not notice an InitCallBackState issued by the fileserver before the BulkStatus call returns, since the InitCallBackState handler looks at tvcp->callback to determine what vcaches to clear callbacks for. In turn, this can cause us to think we have a callback agreement with the fileserver on one of the BulkStatus'd files, when the fileserver does not actually have such a callback agreement. So, set tvcp->callback to the server we are contacting, so if we get an InitCallBackState call from that fileserver, the CBulkFetching state will be cleared, and we will correctly discard the callback information for that vcache. Reviewed-on: http://gerrit.openafs.org/2548 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 37817796c4890683a7e41ed0f3a2fa6a53e1edc7) Change-Id: I3bb9bd6b8c9f7e5ef9f63a62d80cf70629990db6 Reviewed-on: http://gerrit.openafs.org/5647 Tested-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/afs/VNOPS/afs_vnop_lookup.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/src/afs/VNOPS/afs_vnop_lookup.c b/src/afs/VNOPS/afs_vnop_lookup.c index 1b076c05b9..ee6d34f7c5 100644 --- a/src/afs/VNOPS/afs_vnop_lookup.c +++ b/src/afs/VNOPS/afs_vnop_lookup.c @@ -810,6 +810,36 @@ afs_DoBulkStat(struct vcache *adp, long dirCookie, struct vrequest *areqp) tcp = afs_Conn(&adp->fid, areqp, SHARED_LOCK, &rxconn); if (tcp) { hostp = tcp->srvr->server; + + for (i = 0; i < fidIndex; i++) { + /* we must set tvcp->callback before the BulkStatus call, so + * we can detect concurrent InitCallBackState's */ + + afid.Cell = adp->fid.Cell; + afid.Fid.Volume = adp->fid.Fid.Volume; + afid.Fid.Vnode = fidsp[i].Vnode; + afid.Fid.Unique = fidsp[i].Unique; + + do { + retry = 0; + ObtainReadLock(&afs_xvcache); + tvcp = afs_FindVCache(&afid, &retry, 0 /* !stats&!lru */); + ReleaseReadLock(&afs_xvcache); + } while (tvcp && retry); + + if (!tvcp) { + continue; + } + + if ((tvcp->states & CBulkFetching) && + (tvcp->m.Length == statSeqNo)) { + tvcp->callback = hostp; + } + + afs_PutVCache(tvcp); + tvcp = NULL; + } + XSTATS_START_TIME(AFS_STATS_FS_RPCIDX_BULKSTATUS); RX_AFS_GUNLOCK();