jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-22 08:50:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libadmin: Don't use undefined value

Browse Source 
If IsValidCellHandle returns false, then we can jump to
fail_pts_GroupMemberRemove, and end up using a value for
ids.idlist_val which hasn't been defined. Fix this.

Caught by clang-analyzer.

Change-Id: I030d155f9ad2481250e84c31d4d7d26cb39a9c61
Reviewed-on: http://gerrit.openafs.org/2136
Reviewed-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Simon Wilkinson 2010-06-11 23:50:29 +01:00 committed by Derrick Brashear
parent 6c645092ee
commit 5388e1425d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libadmin/pts/afs_ptsAdmin.c
View File

@ -1479,6 +1479,8 @@ pts_GroupMemberRemove(const void *cellHandle, const char *userName,
afs_cell_handle_p c_handle = (afs_cell_handle_p) cellHandle;
idlist ids;
ids.idlist_val = NULL;
/*
* Validate arguments
*/