jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

afs: shake harder in shake-loose-vcaches

Browse Source 
Linux based cache managers will allocate vcaches on demand and
deallocate batches of vcaches in the background. This feature is called
dynamic vcaches.

Vcaches to be deallocated are found by traversing the vcache LRU list
(VLRU) from the oldest vcache to the newest. Up to a target number of
vcaches are attempted to be evicted.  The afs_xvcache lock protecting
the VLRU may be dropped and re-acquired while attempting to evict a
vcache. When this happens, it is possible the VLRU may have changed, so
the traversal of the VLRU is restarted.  This restarting of the VLRU
transversal is limited to 100 iterations to avoid looping indefinitely.

Vcaches which are busy cannot be evicted and remain in the VLRU. When a
busy cache was not evicted and the afs_xvache lock was dropped, the VLRU
traversal is restarted from the end of the VLRU. When the busy vcache is
encountered on the retry, it will trigger additional retries until the
loop limit is reached, at which point the target number of vcaches will
not be deallocated.

This can leave a very large number of unbusy vcaches which are never
deallocated.  On a busy machine, tens of millions of unused vcaches can
remain in memory. When the busy vcache at the end of the VLRU is finally
evicted, the log jam is broken, and the background deamon will hold the
afs_xvcache lock for an excessively long time, hanging the system.

Fix this by moving busy vcaches to the head of the VLRU before
restarting the VLRU traversal. These busy vcaches will be skipped when
retrying the VLRU traversal, allowing the cache manager to make progress
deallocating vcaches down to the target level.

This was already done on the mac osx platform while attempting to evict
vcaches. Move the code to move busy vcaches to the head of the VLRU up
the the platform agnostic caller.

Thanks to Andrew Deason for the initial version of this patch.

Change-Id: I7768d00604e56d8d5369ac5215f7c2ab7996c4eb
Reviewed-on: https://gerrit.openafs.org/11654
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@dson.org>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
This commit is contained in:
Michael Meffie 2015-08-27 13:06:05 -04:00 committed by Benjamin Kaduk
parent 961875cbed
commit 5c136c7d93
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/afs/DARWIN/osi_vcache.c
View File

@ -53,10 +53,7 @@ osi_TryEvictVCache(struct vcache *avc, int *slept, int defersleep) {
* this out, since the iocount we have to hold makes it
* always "fail" */
if (AFSTOV(avc) == tvp) {
if (*slept) {
QRemove(&avc->vlruq);
QAdd(&VLRU, &avc->vlruq);
}
/* Caller will move this vcache to the head of the VLRU. */
return 0;
} else
return 1;

14
src/afs/afs_vcache.c
View File

@ -752,6 +752,7 @@ int
afs_ShakeLooseVCaches(afs_int32 anumber)
{
afs_int32 i, loop;
int evicted;
struct vcache *tvc;
struct afs_q *tq, *uq;
int fv_slept, defersleep = 0;
@ -779,12 +780,23 @@ afs_ShakeLooseVCaches(afs_int32 anumber)
}
fv_slept = 0;
if (osi_TryEvictVCache(tvc, &fv_slept, defersleep))
evicted = osi_TryEvictVCache(tvc, &fv_slept, defersleep);
if (evicted) {
anumber--;
}
if (fv_slept) {
if (loop++ > 100)
break;
if (!evicted) {
/*
* This vcache was busy and we slept while trying to evict it.
* Move this busy vcache to the head of the VLRU so vcaches
* following this busy vcache can be evicted during the retry.
*/
QRemove(&tvc->vlruq);
QAdd(&VLRU, &tvc->vlruq);
}
goto retry; /* start over - may have raced. */
}
if (uq == &VLRU) {