jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 15:30:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

LINUX: Avoid duplicate mntget in afs_linux_raw_open

Browse Source 
In the unlikely event that our afs_dentry_open call fails with
cache_creds, we call afs_dentry_open again with the current creds as a
fallback. However, we call mntget on afs_cacheMnt for each call. So if
we actually hit the second call, we'll have added 2 refs to
afs_cacheMnt, but we only actually opened one file, causing a slight
overcount on afs_cacheMnt refs.

To avoid this, just call mntget once, before any of the
dentry_open-related calls.

Change-Id: I7ec3e8c193dd7782ab629fb5d7615d83f8385b6c
Reviewed-on: http://gerrit.openafs.org/9791
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
This commit is contained in:
Andrew Deason 2013-04-17 01:33:07 -05:00 committed by Derrick Brashear
parent e019429d45
commit 5ccbbda19f
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/afs/LINUX/osi_file.c
View File

@ -54,13 +54,17 @@ afs_linux_raw_open(afs_dcache_id_t *ainode)
tip = dp->d_inode; tip = dp->d_inode;
tip->i_flags |= S_NOATIME; /* Disable updating access times. */ tip->i_flags |= S_NOATIME; /* Disable updating access times. */
/* note that if this is ever changed to recover from errors, we will need
* to put this reference back */
mntget(afs_cacheMnt);
#if defined(STRUCT_TASK_STRUCT_HAS_CRED) #if defined(STRUCT_TASK_STRUCT_HAS_CRED)
/* Use stashed credentials - prevent selinux/apparmor problems */ /* Use stashed credentials - prevent selinux/apparmor problems */
filp = afs_dentry_open(dp, mntget(afs_cacheMnt), O_RDWR, cache_creds); filp = afs_dentry_open(dp, afs_cacheMnt, O_RDWR, cache_creds);
if (IS_ERR(filp)) if (IS_ERR(filp))
filp = afs_dentry_open(dp, mntget(afs_cacheMnt), O_RDWR, current_cred()); filp = afs_dentry_open(dp, afs_cacheMnt, O_RDWR, current_cred());
#else #else
filp = dentry_open(dp, mntget(afs_cacheMnt), O_RDWR); filp = dentry_open(dp, afs_cacheMnt, O_RDWR);
#endif #endif
if (IS_ERR(filp)) if (IS_ERR(filp))
osi_Panic("Can't open file: %d\n", (int) PTR_ERR(filp)); osi_Panic("Can't open file: %d\n", (int) PTR_ERR(filp));