jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 06:50:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

kauth: Add LIB_crypt to LT_libs

Browse Source 
Since OpenAFS 1.0, kauth's Andrew_StringToKey() has contained a
reference to crypt(). This is provided by $(LIB_crypt) (usually
-lcrypt), but not all everything that links against liboafs_kauth.la
also links to LIB_crypt. This causes the build to fail with
--disable-static:

    $ make V=0
      LD  .../src/tbutc/butc
    /usr/bin/ld: ../../src/kauth/.libs/liboafs_kauth.so: undefined reference to `crypt'
    collect2: error: ld returned 1 exit status

    FAILED COMMAND: /bin/bash ../../libtool --quiet --mode=link --tag=CC gcc [...] -o butc [...] ../../src/kauth/liboafs_kauth.la [...] -lafshcrypto -lrokenafs -lpthread -lresolv

To fix this, link against LIB_crypt when building liboafs_kauth.la, so
anything linking against liboafs_kauth.la should also link against
LIB_crypt.

Change-Id: I9f46f3c429848b1ae67c8bf28a7698df0c084892
Reviewed-on: https://gerrit.openafs.org/15992
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
This commit is contained in:
Andrew Deason 2024-12-16 16:53:11 -06:00
parent ca34ae40f6
commit 5d1f1f8609
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/kauth/Makefile.in
View File

@ -22,7 +22,7 @@ LT_deps = $(top_builddir)/src/ubik/liboafs_ubik.la \
$(top_builddir)/src/ptserver/liboafs_prot.la \
$(top_builddir)/src/sys/liboafs_sys.la \
$(top_builddir)/src/rxkad/liboafs_rxkad.la
LT_libs =
LT_libs = $(LIB_crypt)
INSTALL_KAUTH = @INSTALL_KAUTH@