jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 15:30:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

LWP: don't copy pid to a null pointer

Browse Source 
In LWP_CreateProcess we take a pid. if it's null, don't crash.

Change-Id: I2a491788f5ce23a094e65192164838d5bbfc4b31
Reviewed-on: http://gerrit.openafs.org/3556
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Derrick Brashear 2010-12-20 16:36:42 -05:00
parent fa4b1f3aeb
commit 5d218831f3
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lwp/lwp.c
View File

@ -418,7 +418,8 @@ LWP_CreateProcess(void *(*ep) (void *), int stacksize, int priority, void *parm,
/* End of gross hack */
Set_LWP_RC();
*pid = temp;
if (pid)
*pid = temp;
return 0;
} else
return LWP_EINIT;
@ -484,7 +485,8 @@ LWP_CreateProcess2(void *(*ep) (void *), int stacksize, int priority, void *parm
/* End of gross hack */
Set_LWP_RC();
*pid = temp;
if (pid)
*pid = temp;
return 0;
} else
return LWP_EINIT;
@ -641,7 +643,8 @@ LWP_InitializeProcessSupport(int priority, PROCESS * pid)
savecontext(Dispatcher, &temp->context, NULL);
LWPANCHOR.outersp = temp->context.topstack;
Set_LWP_RC();
*pid = temp;
if (pid)
*pid = temp;
/* get minimum stack size from the environment. this allows the administrator
* to change the lwp stack dynamically without getting a new binary version.
@ -1443,7 +1446,8 @@ LWP_CreateProcess(pthread_startroutine_t ep, int stacksize, int priority,
free(lp);
return LWP_ENOMEM;
}
*pid = lp;
if (pid)
*pid = lp;
return LWP_SUCCESS;
}
@ -1494,7 +1498,8 @@ LWP_InitializeProcessSupport(int priority, PROCESS * pid)
int state;
if (initialized) {
*pid = lp;
if (pid)
*pid = lp;
return LWP_SUCCESS;
}
#ifndef LWP_NO_PRIORITIES
@ -1519,7 +1524,8 @@ LWP_InitializeProcessSupport(int priority, PROCESS * pid)
MUTEX_INIT(&lwp_mutex, "lwp", MUTEX_DEFAULT, 0);
MUTEX_ENTER(&lwp_mutex);
initialized = 1;
*pid = lp;
if (pid)
*pid = lp;
return LWP_SUCCESS;
}