From 5dddb87eb362c824dee4b0340a95ca929c71d26f Mon Sep 17 00:00:00 2001 From: Russ Allbery Date: Tue, 19 Jan 2010 17:43:35 -0800 Subject: [PATCH] Avoid executable headers in local include tree sys_prototypes.h, afs_AdminErrors.h, and afs_Admin.h were being installed into include/ in the build tree via ${INSTALL} instead of ${INSTALL_DATA}. rx_prototypes.h was executable in the repository. Install header files non-executable and make rx_prototypes.h non-executable for cleanliness. Discovered by Lintian because the executable permissions were duplicated by make libafs_tree. Change-Id: I609b62f69d1fecc2cdbba7e7442d93e9675c2fa0 Reviewed-on: http://gerrit.openafs.org/1129 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/libadmin/Makefile.in | 2 +- src/libadmin/adminutil/Makefile.in | 2 +- src/rx/rx_prototypes.h | 0 src/sys/Makefile.in | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) mode change 100755 => 100644 src/rx/rx_prototypes.h diff --git a/src/libadmin/Makefile.in b/src/libadmin/Makefile.in index d9e07f07f8..59764ec55e 100644 --- a/src/libadmin/Makefile.in +++ b/src/libadmin/Makefile.in @@ -15,7 +15,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@ all: ${TOP_INCDIR}/afs/afs_Admin.h ${TOP_INCDIR}/afs/afs_Admin.h: afs_Admin.h - ${INSTALL} $? $@ + ${INSTALL_DATA} $? $@ install: ${INSTALL} -d ${DESTDIR}${includedir}/afs diff --git a/src/libadmin/adminutil/Makefile.in b/src/libadmin/adminutil/Makefile.in index ea8fe20119..8a07fcba74 100644 --- a/src/libadmin/adminutil/Makefile.in +++ b/src/libadmin/adminutil/Makefile.in @@ -34,7 +34,7 @@ ${TOP_INCDIR}/afs/afs_utilAdmin.h: afs_utilAdmin.h ${INSTALL_DATA} $? $@ afs_AdminBosErrors.c ${DESTDIR}/include/afs/afs_AdminBosErrors.h: afs_AdminBosErrors.et - ${INSTALL} ${srcdir}/afs_AdminErrors.h ${TOP_INCDIR}/afs + ${INSTALL_DATA} ${srcdir}/afs_AdminErrors.h ${TOP_INCDIR}/afs $(RM) -f afs_AdminBosErrors.c afs_AdminBosErrors.h ${COMPILE_ET} -p ${srcdir} afs_AdminBosErrors.et -h afs_AdminBosErrors cp afs_AdminBosErrors.h ${TOP_INCDIR}/afs/afs_AdminBosErrors.h diff --git a/src/rx/rx_prototypes.h b/src/rx/rx_prototypes.h old mode 100755 new mode 100644 diff --git a/src/sys/Makefile.in b/src/sys/Makefile.in index db397c8af9..ee4239684e 100644 --- a/src/sys/Makefile.in +++ b/src/sys/Makefile.in @@ -58,7 +58,7 @@ ${TOP_INCDIR}/afs/xfsattrs.h: xfsattrs.h ${INSTALL_DATA} $? $@ ${TOP_INCDIR}/afs/sys_prototypes.h: sys_prototypes.h - ${INSTALL} $? $@ + ${INSTALL_DATA} $? $@ ${TOP_LIBDIR}/libsys.a: libsys.a ${INSTALL_DATA} $? $@