jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 23:10:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

OpenBSD: Fix bug in setpag() when group list is empty

Browse Source 
In OpenBSD, the PAG uses the 2nd and 3rd group slots in the task's
group list. If an application sets en empty group list (such as Samba
does), any existing PAG is lost and any new one is NOT set because
the existing code will set the new group count to 2 instead of 3, and
it leaves the first group entry as garbage (whatever random value the
memory contained), thereby totally messing up the task's group list.
This patch fixes it so that it behaves as expected.

Change-Id: Ia718d55cbaad8ed372fba926dbfcb5db52ea684a
Reviewed-on: http://gerrit.openafs.org/1898
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Antoine Verheijen 2010-05-03 15:04:20 -06:00 committed by Derrick Brashear
parent 0ec2239b73
commit 5e24220c3d
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/afs/OBSD/osi_groups.c
View File

@ -81,6 +81,16 @@ setpag(struct proc *proc, struct ucred **cred, afs_uint32 pagvalue,
AFS_STATCNT(setpag);
ngroups = afs_getgroups(*cred, NGROUPS, gidset);
/*
* If the group list is empty, use the task's primary group as the group
* list. Otherwise, when setting the PAG, group 0 will be set to arbitrary
* gibberish and the PAG, which starts at group offset 1, will not be
* properly set because the group count will be wrong (2 instead of 3).
*/
if (ngroups == 0) {
gidset[0] = (*cred)->cr_gid;
ngroups = 1;
}
if (afs_get_pag_from_groups(gidset[1], gidset[2]) == NOPAG) {
/* We will have to shift grouplist to make room for pag */
if (ngroups + 2 > NGROUPS) {