jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cf: Disable pam if --disable-shared

Browse Source 
If we are configured with --enable-kauth and --disable-shared, 'make
install/dest' currently fails for pam, since we never generate the
shared library files:

    make[3]: Entering directory '.../src/pam'
    if [ "xyes" = "xyes" ]; then \
            /usr/bin/install -c -d .../amd64_linux26/dest/lib; \
            /usr/bin/install -c -m 644 .libs/pam_afs.so .../amd64_linux26/dest/lib; \
            /usr/bin/install -c -m 644 .libs/pam_afs.krb.so .../amd64_linux26/dest/lib; \
    fi
    /usr/bin/install: cannot stat '.libs/pam_afs.so': No such file or directory
    /usr/bin/install: cannot stat '.libs/pam_afs.krb.so': No such file or directory
    make[3]: *** [dest] Error 1

Building pam plugins doesn't make sense if shared libraries are
disabled, so just turn off pam if --disable-shared is specified, similar
to what we do if pam headers aren't available.

While we're here, slightly restructure the code for setting HAVE_PAM, to
make it easier to add pam-disabling conditions like this.

Change-Id: I7d1f98267ba342dbd7290de40a07da904e65dbe3
Reviewed-on: https://gerrit.openafs.org/15998
Reviewed-by: Ben Huntsman <ben@huntsmans.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
This commit is contained in:
Andrew Deason 2024-12-18 15:25:25 -06:00
parent 5196ca7b54
commit 60314cbe8e
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/cf/options.m4
View File

@ -360,11 +360,12 @@ if test "$enable_debug_locks" = yes; then
AC_DEFINE(OPR_DEBUG_LOCKS, 1, [turn on lock debugging in opr]) AC_DEFINE(OPR_DEBUG_LOCKS, 1, [turn on lock debugging in opr])
fi fi
if test "$ac_cv_header_security_pam_modules_h" = yes -a "$enable_pam" = yes; then dnl Only build pam if pam is enabled, we have pam headers, and we have shared
HAVE_PAM="yes" dnl libs.
else AS_IF([test x"$enable_pam" != xyes], [HAVE_PAM=no],
HAVE_PAM="no" [test x"$ac_cv_header_security_pam_modules_h" != xyes], [HAVE_PAM=no],
fi [test x"$enable_shared" != xyes], [HAVE_PAM=no],
[HAVE_PAM=yes])
AC_SUBST(HAVE_PAM) AC_SUBST(HAVE_PAM)
if test "$enable_login" = yes; then if test "$enable_login" = yes; then