jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 06:50:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ptserver: Remove duplicate ubik_SetLock in listSuperGroups

Browse Source 
It looks like a call to ubik_SetLock(.. LOCKREAD) was left in
place in listSuperGroups after locking was moved to ReadPreamble
in commit a6d64d70 (ptserver: Refactor per-call ubik initialisation)
When compiled with 'supergroups', and once contacted by
"pts mem -expandgroups ..", ptserver will therefore abort() with
Ubik: Internal Error: attempted to take lock twice
This patch removes the superfluous ubik_SetLock.

FIXES 135147

Change-Id: I8779710a6d68e4126fc482123b576690d86e4225
Reviewed-on: https://gerrit.openafs.org/14338
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
This commit is contained in:
Jan Iven 2020-09-01 14:51:25 +02:00 committed by Benjamin Kaduk
parent 16bae98ec5
commit 696f2ec67b
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ptserver/ptprocs.c
View File

@ -1787,10 +1787,6 @@ listSuperGroups(struct rx_call *call, afs_int32 aid, prlist *alist,
if (!pr_noAuth && restrict_anonymous && *cid == ANONYMOUSID)
ABORT_WITH(tt, PRPERM);
code = ubik_SetLock(tt, 1, 1, LOCKREAD);
if (code)
ABORT_WITH(tt, code);
temp = FindByID(tt, aid);
if (!temp)
ABORT_WITH(tt, PRNOENT);