jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-21 00:10:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

viced: Remove pointless braces

Browse Source 
Doing if ((a==b)) is unecessary. It's also potentially dangerous, as
that's the syntax required to do assignment within an if statement.
clang now issues warnings (errors in -Werror mode) when it encounters
these.

Remove pointless braces from viced to make clang happy.

Change-Id: Iee8c1d60cc2296fefd0e7f82127821dcefb931ec
Reviewed-on: http://gerrit.openafs.org/7085
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
This commit is contained in:
Simon Wilkinson 2012-03-30 19:34:53 +01:00 committed by Derrick Brashear
parent 350b5d5877
commit 6d83b33324
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/viced/afsfileprocs.c
View File

@ -2875,7 +2875,7 @@ common_StoreData64(struct rx_call *acall, struct AFSFid *Fid,
/* set volume synchronization information */
SetVolumeSync(Sync, volptr);
if ((targetptr->disk.type == vSymlink)) {
if (targetptr->disk.type == vSymlink) {
/* Should we return a better error code here??? */
errorCode = EISDIR;
goto Bad_StoreData;
@ -4772,7 +4772,7 @@ SAFSS_ExtendLock(struct rx_call *acall, struct AFSFid *Fid,
(void)PutVolumePackage(acall, parentwhentargetnotdir, targetptr,
(Vnode *) 0, volptr, &client);
if ((errorCode == VREADONLY)) /* presumably, we already granted this lock */
if (errorCode == VREADONLY) /* presumably, we already granted this lock */
errorCode = 0; /* under our generous policy re RO vols */
ViceLog(2, ("SAFS_ExtendLock returns %d\n", errorCode));
@ -4881,7 +4881,7 @@ SAFSS_ReleaseLock(struct rx_call *acall, struct AFSFid *Fid,
(void)PutVolumePackage(acall, parentwhentargetnotdir, targetptr,
(Vnode *) 0, volptr, &client);
if ((errorCode == VREADONLY)) /* presumably, we already granted this lock */
if (errorCode == VREADONLY) /* presumably, we already granted this lock */
errorCode = 0; /* under our generous policy re RO vols */
ViceLog(2, ("SAFS_ReleaseLock returns %d\n", errorCode));