jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-21 00:10:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

afs: Add some comments explaining 'needvalid'

Browse Source 
Add some comments to try and help explain the meaning of the
'needvalid' parameter to GetDSlot, added in
1a672914ab.

Change-Id: I4f1c704fa131df07e671f46b1b7575fbf607fce4
Reviewed-on: http://gerrit.openafs.org/7429
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
This commit is contained in:
Andrew Deason 2012-05-21 12:28:58 -05:00 committed by Derrick Brashear
parent cfae6cda3f
commit 6f6c799c4b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/afs/afs_dcache.c
View File

@ -2599,6 +2599,7 @@ afs_WriteThroughDSlots(void)
* *
* Parameters: * Parameters:
* aslot : Dcache slot to look at. * aslot : Dcache slot to look at.
* needvalid : Whether the specified slot should already exist
* *
* Environment: * Environment:
* Must be called with afs_xdcache write-locked. * Must be called with afs_xdcache write-locked.
@ -2626,6 +2627,9 @@ afs_MemGetDSlot(afs_int32 aslot, int needvalid)
return tdc; return tdc;
} }
/* if 'needvalid' is true, the slot must already exist and be populated
* somewhere. for memcache, the only place that dcache entries exist is
* in memory, so if we did not find it above, something is very wrong. */
osi_Assert(!needvalid); osi_Assert(!needvalid);
if (!afs_freeDSList) if (!afs_freeDSList)
@ -2687,6 +2691,7 @@ unsigned int last_error = 0, lasterrtime = 0;
* *
* Parameters: * Parameters:
* aslot : Dcache slot to look at. * aslot : Dcache slot to look at.
* needvalid : Whether the specified slot should already exist
* *
* Environment: * Environment:
* afs_xdcache lock write-locked. * afs_xdcache lock write-locked.