From 77aa6c65b74e46c77dfaf440745496ab98b14244 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 2 Mar 2013 09:33:12 +0000 Subject: [PATCH] kauth: Don't overflow cell string The cell string within a ktc_principal is only 64 characters long. Be careful not to overflow it. Caught by coverity (#985829) Change-Id: I761dfcf5eebf1bd4ef31aa5982a2593e5317257b Reviewed-on: http://gerrit.openafs.org/9350 Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/kauth/knfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kauth/knfs.c b/src/kauth/knfs.c index 4b4be5a53a..81a03d64b7 100644 --- a/src/kauth/knfs.c +++ b/src/kauth/knfs.c @@ -183,7 +183,7 @@ GetTokens(afs_int32 ahost, afs_int32 auid) sprintf(clientName.name, "Unix UID %d", ct.ViceId); clientName.instance[0] = 0; } - strcpy(clientName.cell, tp); + strlcpy(clientName.cell, tp, sizeof(clientName.cell)); tokenExpireTime = token.endTime; strcpy(UserName, clientName.name);