jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libadmin: Don't overflow volume name

Browse Source 
The maximum volume name length in the VLDB RPCs is VL_MAXNAMELEN
(65), not 64 as used as a hardcoded value in vsprocs. Switch to
using the defined value, and also use strlcat to check that we
don't overflow this.

Caught by coverity (#985849)

Change-Id: Idde2cf8362bbd48538fafcd8c8d98e1f71cc15e1
Reviewed-on: http://gerrit.openafs.org/9353
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
This commit is contained in:
Simon Wilkinson 2013-03-02 09:47:53 +00:00 committed by Jeffrey Altman
parent 4f9ec8396d
commit 79abe9d68e
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/libadmin/vos/vsprocs.c
View File

@ -1323,14 +1323,18 @@ GetTrans(afs_cell_handle_p cellHandle, struct nvldbentry *vldbEntryPtr,
/* If the volume does not exist, create it */
if (!volid || tst) {
char volname[64];
char volname[VL_MAXNAMELEN];
if (volid && (tst != VNOVOL)) {
goto fail_GetTrans;
}
strcpy(volname, vldbEntryPtr->name);
strcat(volname, ".readonly");
strlcpy(volname, vldbEntryPtr->name, sizeof(volname));
if (strlcat(volname, ".readonly", sizeof(volname))
>= sizeof(volname)) {
tst = ENOMEM;
goto fail_GetTrans;
}
tst =
AFSVolCreateVolume(*connPtr, vldbEntryPtr->serverPartition[index],