jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 23:40:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows: AFSInitFcb assign pFcb->ObjectInformation

Browse Source 
In AFSInitFcb() assign pFcb->ObjectInformation before the
InterlockedExchangePointer call and not afterwards.  Assigning
it afterwards leaves a small race where the ObjectInformation
value will be invalid.

Change-Id: Ie79587e0b2f161b7ff612fc4fb283135bafd1085
Reviewed-on: http://gerrit.openafs.org/8222
Reviewed-by: Rod Widdowson <rdw@steadingsoftware.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
This commit is contained in:
Jeffrey Altman 2012-10-02 21:09:35 -04:00
parent 7fd9890162
commit 7b1115d470
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/WINNT/afsrdr/kernel/lib/AFSFcbSupport.cpp
View File

@ -260,8 +260,11 @@ AFSInitFcb( IN AFSDirectoryCB *DirEntry)
pFcb->Header.NodeTypeCode = AFS_INVALID_FCB; pFcb->Header.NodeTypeCode = AFS_INVALID_FCB;
} }
pFcb->ObjectInformation = pObjectInfo;
// //
// Initialize some fields in the Fcb // Swap the allocated FCB into the ObjectInformation structure if it
// does not already have one.
// //
if ( InterlockedCompareExchangePointer( (PVOID *)&pObjectInfo->Fcb, pFcb, NULL) != NULL) if ( InterlockedCompareExchangePointer( (PVOID *)&pObjectInfo->Fcb, pFcb, NULL) != NULL)
@ -286,8 +289,6 @@ AFSInitFcb( IN AFSDirectoryCB *DirEntry)
try_return( ntStatus = STATUS_REPARSE); try_return( ntStatus = STATUS_REPARSE);
} }
pFcb->ObjectInformation = pObjectInfo;
AFSDbgLogMsg( AFS_SUBSYSTEM_FCB_REF_COUNTING, AFSDbgLogMsg( AFS_SUBSYSTEM_FCB_REF_COUNTING,
AFS_TRACE_LEVEL_VERBOSE, AFS_TRACE_LEVEL_VERBOSE,
"AFSInitFcb Initialized Fcb %08lX Name %wZ\n", "AFSInitFcb Initialized Fcb %08lX Name %wZ\n",