jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

LINUX: replace BUG() call with osi_Panic() in osi_linux_free

Browse Source 
If osi_linux_free fails, it printf's an error message, then calls BUG().
This is the sole open-coded call to BUG() in OpenAFS; all other calls
to BUG() are indirect via osi_Panic().

For consistency, eliminate this direct BUG() call by replacing the
printf and BUG() with an equivalent osi_Panic().  This also ensures that
the error messsage is logged as critical, and prefixed with "openafs:".

Change-Id: Id319dffa859308528a66991bbbc522ca49552d51
Reviewed-on: https://gerrit.openafs.org/14250
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: Benjamin Kaduk <kaduk@mit.edu>
This commit is contained in:
Mark Vitale 2020-06-18 13:43:35 -04:00 committed by Benjamin Kaduk
parent d8ec294534
commit 7c9fb44557
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/afs/LINUX/osi_alloc.c
View File

@ -305,8 +305,7 @@ osi_linux_free(void *addr)
afs_atomlist_put(al_mem_pool, lmp); /* return osi_linux_mem struct to pool */
afs_linux_cur_allocs--;
} else {
printf("osi_linux_free: failed to remove chunk from hashtable\n");
BUG();
osi_Panic("osi_linux_free: failed to remove chunk from hashtable\n");
}
mutex_unlock(&afs_linux_alloc_sem);